Skip to content
Commit 39307655 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd4: fix security flavor of NFSv4.0 callback

Commit d5497fc6

 "nfsd4: move rq_flavor
into svc_cred" forgot to remove cl_flavor from the client, leaving two
places (cl_flavor and cl_cred.cr_flavor) for the flavor to be stored.
After that patch, the latter was the one that was updated, but the
former was the one that the callback used.

Symptoms were a long delay on utime().  This is because the utime()
generated a setattr which recalled a delegation, but the cb_recall was
ignored by the client because it had the wrong security flavor.

Cc: stable@vger.kernel.org
Tested-by: default avatarJamie Heilman <jamie@audible.transient.net>
Reported-by: default avatarJamie Heilman <jamie@audible.transient.net>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent d9875690
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment