Skip to content
Commit 2512e40e authored by Corey Minyard's avatar Corey Minyard
Browse files

ipmi: Rework SMI registration failure



There were certain situations where ipmi_register_smi() would
return a failure, but the interface would still be registered
and would need to be unregistered.  This is obviously a bad
design and resulted in an oops in certain failure cases.

If the interface is started up in ipmi_register_smi(), then
an error occurs, shut down the interface there so the
cleanup can be done properly.

Fix the various smi users, too.

Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
Reported-by: default avatarJustin Ernst <justin.ernst@hpe.com>
Tested-by: default avatarJustin Ernst <justin.ernst@hpe.com>
Cc: Andrew Banman <abanman@hpe.com>
Cc: Russ Anderson <russ.anderson@hpe.com>
Cc: <stable@vger.kernel.org> # 4.18.x
parent cd2315d4
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment