Skip to content
Commit 023f2340 authored by Peter Zijlstra's avatar Peter Zijlstra
Browse files

objtool: Fix weak hole vs prefix symbol



Boris (and the robot) reported that objtool grew a new complaint about
unreachable instructions. Upon inspection it was immediately clear
the __weak zombie instructions struck again.

For the unweary, the linker will simply remove the symbol for
overriden __weak symbols but leave the instructions in place, creating
unreachable instructions -- and objtool likes to report these.

Commit 4adb2368 ("objtool: Ignore extra-symbol code") was supposed
to have dealt with that, but the new commit 9f2899fe ("objtool:
Add option to generate prefix symbols") subtly broke that logic by
created unvisited symbols.

Fixes: 9f2899fe ("objtool: Add option to generate prefix symbols")
Reported-by: default avatarBorislav Petkov <bp@alien8.de>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
parent 19526717
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment