Skip to content
Commit bb8ee7f5 authored by Mike Frysinger's avatar Mike Frysinger
Browse files

manifest_xml: unify bool & int parsing

We've been overly lenient with boolean parsing by ignoring invalid
values as "false" even if the user didn't intend that.  Turn all
unknown values into warnings to avoid breaking existing manifests,
and unify the parsing logic in a helper to simplify.

We've been stricter about numbers, but still copying & pasting
inconsistent code.  Add a helper for this too.  For out of range
sync-j numbers (i.e. less than 1), throw a warning for now, but
mark it for future hard failures.

Change-Id: I924162b8036e6a5f1e31b6ebb24b6a26ed63712d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/256457


Reviewed-by: default avatarMichael Mortensen <mmortensen@google.com>
Tested-by: default avatarMike Frysinger <vapier@google.com>
parent 23d7dafd
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment