Skip to content
  1. Sep 20, 2023
    • Uwe Kleine-König's avatar
      net: dsa: hirschmann: Convert to platform remove callback returning void · beb8592d
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
      Reviewed-by: default avatarKurt Kanzenbach <kurt@linutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      beb8592d
    • Uwe Kleine-König's avatar
      net: dsa: bcm_sf2: Convert to platform remove callback returning void · 75f5205f
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      75f5205f
    • Uwe Kleine-König's avatar
      net: dsa: b53: Convert to platform remove callback returning void · c306171d
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c306171d
    • David S. Miller's avatar
      Merge branch 'net-platform-remove-void' · 6f0b985d
      David S. Miller authored
      Uwe Kleine-König says:
      
      ====================
      net: ethernet: Convert to platform remove callback returning void
      
      this series convert nearly all platform drivers below
      drivers/net/ethernet to use remove_new. The motivation is to get rid of
      an integer return code that is (mostly) ignored by the platform driver
      core and error prone on the driver side.
      
      There are 3 drivers I didn't convert (yet):
      
       drivers/net/ethernet/ti/cpsw.c
       drivers/net/ethernet/ti/cpsw_new.c
       drivers/net/ethernet/ti/am65-cpsw-nuss.c
      
      These are a bit more complicated because they don't always return 0 in
      .remove(). Unless someone is quicker than me, I'll address them in
      separate patches at a later time.
      
      See commit 5c5a7680
      
       ("platform: Provide a remove callback that
      returns no value") for an extended explanation and the eventual goal.
      
      There are no interdependencies between the patches. As there are still
      quite a few drivers to convert, I'm happy about every patch that makes
      it in. So even if there is a merge conflict with one patch until you
      apply, please apply the remainder of this series anyhow.
      ====================
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6f0b985d
    • Uwe Kleine-König's avatar
      net: ethernet: xscale: Convert to platform remove callback returning void · d74a5c15
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Acked-by: default avatarKrzysztof Hałasa <khalasa@piap.pl>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d74a5c15
    • Uwe Kleine-König's avatar
      net: ethernet: xilinx: Convert to platform remove callback returning void · 2e0ec0af
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2e0ec0af
    • Uwe Kleine-König's avatar
      net: ethernet: wiznet: Convert to platform remove callback returning void · 46b56684
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      46b56684
    • Uwe Kleine-König's avatar
      net: ethernet: via: Convert to platform remove callback returning void · 70680f17
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      70680f17
    • Uwe Kleine-König's avatar
      net: ethernet: tundra: Convert to platform remove callback returning void · 2f961952
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      2f961952
    • Uwe Kleine-König's avatar
      net: ethernet: ti: Convert to platform remove callback returning void · 231ea972
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> # cpmac
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      231ea972
    • Uwe Kleine-König's avatar
      net: ethernet: sunplus: Convert to platform remove callback returning void · ede778ed
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ede778ed
    • Uwe Kleine-König's avatar
      net: ethernet: sun: Convert to platform remove callback returning void · 8f4e45a0
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8f4e45a0
    • Uwe Kleine-König's avatar
      net: ethernet: socionext: Convert to platform remove callback returning void · d3cd3245
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d3cd3245
    • Uwe Kleine-König's avatar
      net: ethernet: smsc: Convert to platform remove callback returning void · e8e2c863
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e8e2c863
    • Uwe Kleine-König's avatar
      net: ethernet: sgi: Convert to platform remove callback returning void · 506a327c
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      506a327c
    • Uwe Kleine-König's avatar
      net: ethernet: seeq: Convert to platform remove callback returning void · 02c74030
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      02c74030
    • Uwe Kleine-König's avatar
      net: ethernet: samsung: Convert to platform remove callback returning void · 6e8b0ef7
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6e8b0ef7
    • Uwe Kleine-König's avatar
      net: ethernet: renesas: Convert to platform remove callback returning void · 0b4f04e2
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
      Reviewed-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0b4f04e2
    • Uwe Kleine-König's avatar
      net: ethernet: qualcomm: Convert to platform remove callback returning void · 51802365
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Acked-by: default avatarTimur Tabi <timur@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      51802365
    • Uwe Kleine-König's avatar
      net: ethernet: nxp: Convert to platform remove callback returning void · 241882d7
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      241882d7
    • Uwe Kleine-König's avatar
      net: ethernet: ni: Convert to platform remove callback returning void · 0f09f4e7
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0f09f4e7
    • Uwe Kleine-König's avatar
      net: ethernet: natsemi: Convert to platform remove callback returning void · b83fb509
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b83fb509
    • Uwe Kleine-König's avatar
      net: ethernet: natsemi: Convert to platform remove callback returning void · 9f0243d9
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9f0243d9
    • Uwe Kleine-König's avatar
      net: ethernet: mscc: Convert to platform remove callback returning void · 0eaca7a9
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0eaca7a9
    • Uwe Kleine-König's avatar
      net: ethernet: moxa:: Convert to platform remove callback returning void · 253f9c47
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      253f9c47
    • Uwe Kleine-König's avatar
      net: ethernet: microchip: Convert to platform remove callback returning void · 5253ae3a
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5253ae3a
    • Uwe Kleine-König's avatar
      net: ethernet: micrel: Convert to platform remove callback returning void · bae04ae2
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bae04ae2
    • Uwe Kleine-König's avatar
      net: ethernet: mellanox: Convert to platform remove callback returning void · e1847009
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e1847009
    • Uwe Kleine-König's avatar
      net: ethernet: mediatek: Convert to platform remove callback returning void · 5b6ce173
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5b6ce173
    • Uwe Kleine-König's avatar
      net: ethernet: marvell: Convert to platform remove callback returning void · fee02f49
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fee02f49
    • Uwe Kleine-König's avatar
      net: ethernet: litex: Convert to platform remove callback returning void · 36b80b83
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Acked-by: default avatarGabriel Somlo <gsomlo@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      36b80b83
    • Uwe Kleine-König's avatar
      net: ethernet: lantiq_xrx200: Convert to platform remove callback returning void · adbb2706
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      adbb2706
    • Uwe Kleine-König's avatar
      net: ethernet: lantiq_etop: Convert to platform remove callback returning void · e791aa06
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e791aa06
    • Uwe Kleine-König's avatar
      net: ethernet: korina: Convert to platform remove callback returning void · 551598a1
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      551598a1
    • Uwe Kleine-König's avatar
      net: ethernet: ibm: Convert to platform remove callback returning void · ac35a3c4
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ac35a3c4
    • Uwe Kleine-König's avatar
      net: ethernet: i825xx: Convert to platform remove callback returning void · e5a6d397
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e5a6d397
    • Uwe Kleine-König's avatar
      net: ethernet: hisilicon: Convert to platform remove callback returning void · e5835a0a
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e5835a0a
    • Uwe Kleine-König's avatar
      net: ethernet: faraday: Convert to platform remove callback returning void · dc715af3
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert these drivers from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      dc715af3
    • Uwe Kleine-König's avatar
      net: ethernet: ethoc: Convert to platform remove callback returning void · 4cc08098
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      4cc08098
    • Uwe Kleine-König's avatar
      net: ethernet: engleder: Convert to platform remove callback returning void · d2e6c2ea
      Uwe Kleine-König authored
      
      
      The .remove() callback for a platform driver returns an int which makes
      many driver authors wrongly assume it's possible to do error handling by
      returning an error code. However the value returned is ignored (apart
      from emitting a warning) and this typically results in resource leaks.
      To improve here there is a quest to make the remove callback return
      void. In the first step of this quest all drivers are converted to
      .remove_new() which already returns void. Eventually after all drivers
      are converted, .remove_new() is renamed to .remove().
      
      Trivially convert this driver from always returning zero in the remove
      callback to the void returning variant.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d2e6c2ea