Skip to content
  1. Dec 22, 2022
  2. Dec 09, 2022
  3. Dec 08, 2022
  4. Dec 07, 2022
  5. Dec 06, 2022
    • Takashi Iwai's avatar
      Merge tag 'asoc-v6.2' of... · 8ec2d95f
      Takashi Iwai authored
      Merge tag 'asoc-v6.2' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-next
      
      ASoC: Updates for v6.2
      
      This is a fairly sedate release for the core code, but there's been a
      lot of driver work especially around the x86 platforms and device tree
      updates:
      
       - More cleanups of the DAPM code from Morimoto-san.
       - Factoring out of mapping hw_params onto SoundWire configuration by
         Charles Keepax.
       - The ever ongoing overhauls of the Intel DSP code continue, including
         support for loading libraries and probes with IPC4 on SOF.
       - Support for more sample formats on JZ4740.
       - Lots of device tree conversions and fixups.
       - Support for Allwinner D1, a range of AMD and Intel systems, Mediatek
         systems with multiple DMICs, Nuvoton NAU8318, NXP fsl_rpmsg and
         i.MX93, Qualcomm AudioReach Enable, MFC and SAL, RealTek RT1318 and
         Rockchip RK3588
      
      There's more cross tree updates than usual, though all fairly minor:
      
       - Some OMAP board file updates that were depedencies for removing their
         providers in ASoC, as part of a wider effort removing the support for
         the relevant OMAP platforms.
       - A new I2C API required for updates to the new I2C probe API.
       - A DRM update making use of a new API for fixing the capabilities
         advertised via hdmi-codec.
      
      Since this is being sent early I might send some more stuff if you've
      not yet sent your pull request and there's more come in.
      8ec2d95f
    • Gaosheng Cui's avatar
      ALSA: mts64: fix possible null-ptr-defer in snd_mts64_interrupt · cf2ea3c8
      Gaosheng Cui authored
      
      
      I got a null-ptr-defer error report when I do the following tests
      on the qemu platform:
      
      make defconfig and CONFIG_PARPORT=m, CONFIG_PARPORT_PC=m,
      CONFIG_SND_MTS64=m
      
      Then making test scripts:
      cat>test_mod1.sh<<EOF
      modprobe snd-mts64
      modprobe snd-mts64
      EOF
      
      Executing the script, perhaps several times, we will get a null-ptr-defer
      report, as follow:
      
      syzkaller:~# ./test_mod.sh
      snd_mts64: probe of snd_mts64.0 failed with error -5
      modprobe: ERROR: could not insert 'snd_mts64': No such device
       BUG: kernel NULL pointer dereference, address: 0000000000000000
       #PF: supervisor write access in kernel mode
       #PF: error_code(0x0002) - not-present page
       PGD 0 P4D 0
       Oops: 0002 [#1] PREEMPT SMP PTI
       CPU: 0 PID: 205 Comm: modprobe Not tainted 6.1.0-rc8-00588-g76dcd734eca2 #6
       Call Trace:
        <IRQ>
        snd_mts64_interrupt+0x24/0xa0 [snd_mts64]
        parport_irq_handler+0x37/0x50 [parport]
        __handle_irq_event_percpu+0x39/0x190
        handle_irq_event_percpu+0xa/0x30
        handle_irq_event+0x2f/0x50
        handle_edge_irq+0x99/0x1b0
        __common_interrupt+0x5d/0x100
        common_interrupt+0xa0/0xc0
        </IRQ>
        <TASK>
        asm_common_interrupt+0x22/0x40
       RIP: 0010:_raw_write_unlock_irqrestore+0x11/0x30
        parport_claim+0xbd/0x230 [parport]
        snd_mts64_probe+0x14a/0x465 [snd_mts64]
        platform_probe+0x3f/0xa0
        really_probe+0x129/0x2c0
        __driver_probe_device+0x6d/0xc0
        driver_probe_device+0x1a/0xa0
        __device_attach_driver+0x7a/0xb0
        bus_for_each_drv+0x62/0xb0
        __device_attach+0xe4/0x180
        bus_probe_device+0x82/0xa0
        device_add+0x550/0x920
        platform_device_add+0x106/0x220
        snd_mts64_attach+0x2e/0x80 [snd_mts64]
        port_check+0x14/0x20 [parport]
        bus_for_each_dev+0x6e/0xc0
        __parport_register_driver+0x7c/0xb0 [parport]
        snd_mts64_module_init+0x31/0x1000 [snd_mts64]
        do_one_initcall+0x3c/0x1f0
        do_init_module+0x46/0x1c6
        load_module+0x1d8d/0x1e10
        __do_sys_finit_module+0xa2/0xf0
        do_syscall_64+0x37/0x90
        entry_SYSCALL_64_after_hwframe+0x63/0xcd
        </TASK>
       Kernel panic - not syncing: Fatal exception in interrupt
       Rebooting in 1 seconds..
      
      The mts wa not initialized during interrupt,  we add check for
      mts to fix this bug.
      
      Fixes: 68ab801e ("[ALSA] Add snd-mts64 driver for ESI Miditerminal 4140")
      Signed-off-by: default avatarGaosheng Cui <cuigaosheng1@huawei.com>
      Link: https://lore.kernel.org/r/20221206061004.1222966-1-cuigaosheng1@huawei.com
      
      
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      cf2ea3c8
    • Mark Brown's avatar
      ASoC: Intel: avs: Data probing and fw logging · 8e378ea1
      Mark Brown authored
      Merge series from Cezary Rojewski <cezary.rojewski@intel.com>:
      
      The patchset focuses on debug functionality for the avs-driver.
      Two major blocks are covered here: data probing and AudioDSP firmware
      logging. Both are configured and controlled through debugfs.
      
      Data probing is a AudioDSP debug functionality which allows for
      gathering the actual data that is being routed to or from a module.
      Helps in debugging its processing capabilities - navigate to a specific
      module which may have caused a glitch within a pipeline (set of modules
      bound together).
      
      First few allow for assigning compress stream to a HDAudio stream, what
      is currently limited to pcm substreams only. These patches were already
      present on this list and reviewed in the past [1].
      
      The next few tidy existing debug-related code up so it's ready for
      addition of new functionalities and make it clear which part of the avs
      is debug related and which is not. These also simplify the existing
      locking around the trace fifo.
      
      Afterward, debug-related IPCs are defined along with stub soc-component
      and compress DAI operations. Not much is done there as it's not a
      standard PCM streaming scenario. Most code found in compress operations
      is inherited from the HOST side of HDAudio streaming found in pcm.c
      file of the driver.
      
      Finally, a debugfs file operations are defined. These facilitate
      connecting to DSP modules from which the data shall be gathered as well
      as control and configuration of firmware logging. Additionally, entries
      are added to allow for dumping snapshots of key memory windows.
      8e378ea1
    • Yang Yingliang's avatar
      ASoC: sof_es8336: fix possible use-after-free in sof_es8336_remove() · 1b41beaa
      Yang Yingliang authored
      
      
      sof_es8336_remove() calls cancel_delayed_work(). However, that
      function does not wait until the work function finishes. This
      means that the callback function may still be running after
      the driver's remove function has finished, which would result
      in a use-after-free.
      
      Fix by calling cancel_delayed_work_sync(), which ensures that
      the work is properly cancelled, no longer running, and unable
      to re-schedule itself.
      
      Fixes: 89cdb224 ("ASoC: sof_es8336: reduce pop noise on speaker")
      Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
      Acked-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Link: https://lore.kernel.org/r/20221205143721.3988988-1-yangyingliang@huawei.com
      
      
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      1b41beaa
    • Mark Brown's avatar
      Add SOF panic dump support for AMD platform. · 9472382d
      Mark Brown authored
      Merge series from V sujith kumar Reddy <Vsujithkumar.Reddy@amd.com>:
      
      Fix an issue with starting the ACP DSP and support debug dumps to aid
      maintainability.
      9472382d
    • Philipp Jungkamp's avatar
      ALSA: patch_realtek: Fix Dell Inspiron Plus 16 · 2912cdda
      Philipp Jungkamp authored
      
      
      The Dell Inspiron Plus 16, in both laptop and 2in1 form factor, has top
      speakers connected on NID 0x17, which the codec reports as unconnected.
      These speakers should be connected to the DAC on NID 0x03.
      
      Signed-off-by: default avatarPhilipp Jungkamp <p.jungkamp@gmx.net>
      Link: https://lore.kernel.org/r/20221205163713.7476-1-p.jungkamp@gmx.net
      
      
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      2912cdda
    • Vitaly Rodionov's avatar
      ALSA: hda/cirrus: Add extra 10 ms delay to allow PLL settle and lock. · 9fb9fa18
      Vitaly Rodionov authored
      
      
      New HW platforms with multiple CS42L42 parts, faster CPU and i2c
      requre some extra delay to allow PLL to settle and lock. Adding
      extra 10ms delay.
      
      Signed-off-by: default avatarVitaly Rodionov <vitalyr@opensource.cirrus.com>
      Link: https://lore.kernel.org/r/20221205145713.23852-1-vitalyr@opensource.cirrus.com
      
      
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      9fb9fa18
  6. Dec 05, 2022