Skip to content
  1. Sep 14, 2021
  2. Sep 08, 2021
    • Joakim Zhang's avatar
      net: stmmac: fix system hang caused by eee_ctrl_timer during suspend/resume · 276aae37
      Joakim Zhang authored
      commit 5f585913 ("net: stmmac: delete the eee_ctrl_timer after
      napi disabled"), this patch tries to fix system hang caused by eee_ctrl_timer,
      unfortunately, it only can resolve it for system reboot stress test. System
      hang also can be reproduced easily during system suspend/resume stess test
      when mount NFS on i.MX8MP EVK board.
      
      In stmmac driver, eee feature is combined to phylink framework. When do
      system suspend, phylink_stop() would queue delayed work, it invokes
      stmmac_mac_link_down(), where to deactivate eee_ctrl_timer synchronizly.
      In above commit, try to fix issue by deactivating eee_ctrl_timer obviously,
      but it is not enough. Looking into eee_ctrl_timer expire callback
      stmmac_eee_ctrl_timer(), it could enable hareware eee mode again. What is
      unexpected is that LPI interrupt (MAC_Interrupt_Enable.LPIEN bit) is always
      asserted. This interrupt has chance to be issued when LPI state entry/exit
      from the MAC, and at that time, clock could have been already disabled.
      The result is that system hang when driver try to touch register from
      interrupt handler.
      
      The reason why above commit can fix system hang issue in stmmac_release()
      is that, deactivate eee_ctrl_timer not just after napi disabled, further
      after irq freed.
      
      In conclusion, hardware would generate LPI interrupt when clock has been
      disabled during suspend or resume, since hardware is in eee mode and LPI
      interrupt enabled.
      
      Interrupts from MAC, MTL and DMA level are enabled and never been disabled
      when system suspend, so postpone clocks management from suspend stage to
      noirq suspend stage should be more safe.
      
      Fixes: 5f585913
      
       ("net: stmmac: delete the eee_ctrl_timer after napi disabled")
      Signed-off-by: default avatarJoakim Zhang <qiangqing.zhang@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      276aae37
    • Alex Elder's avatar
      net: ipa: initialize all filter table slots · b5c10223
      Alex Elder authored
      There is an off-by-one problem in ipa_table_init_add(), when
      initializing filter tables.
      
      In that function, the number of filter table entries is determined
      based on the number of set bits in the filter map.  However that
      count does *not* include the extra "slot" in the filter table that
      holds the filter map itself.  Meanwhile, ipa_table_addr() *does*
      include the filter map in the memory it returns, but because the
      count it's provided doesn't include it, it includes one too few
      table entries.
      
      Fix this by including the extra slot for the filter map in the count
      computed in ipa_table_init_add().
      
      Note: ipa_filter_reset_table() does not have this problem; it resets
      filter table entries one by one, but does not overwrite the filter
      bitmap.
      
      Fixes: 2b9feef2
      
       ("soc: qcom: ipa: filter and routing tables")
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b5c10223
    • Nathan Rossi's avatar
      net: phylink: Update SFP selected interface on advertising changes · ea269a6f
      Nathan Rossi authored
      
      
      Currently changes to the advertising state via ethtool do not cause any
      reselection of the configured interface mode after the SFP is already
      inserted and initially configured.
      
      While it is not typical to change the advertised link modes for an
      interface using an SFP in certain use cases it is desirable. In the case
      of a SFP port that is capable of handling both SFP and SFP+ modules it
      will automatically select between 1G and 10G modes depending on the
      supported mode of the SFP. However if the SFP module is capable of
      working in multiple modes (e.g. a SFP+ DAC that can operate at 1G or
      10G), one end of the cable may be attached to a SFP 1000base-x port thus
      the SFP+ end must be manually configured to the 1000base-x mode in order
      for the link to be established.
      
      This change causes the ethtool setting of advertised mode changes to
      reselect the interface mode so that the link can be established.
      Additionally when a module is inserted the advertising mode is reset to
      match the supported modes of the module.
      
      Signed-off-by: default avatarNathan Rossi <nathan.rossi@digi.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ea269a6f
    • Arnd Bergmann's avatar
      ne2000: fix unused function warning · d7e203ff
      Arnd Bergmann authored
      Geert noticed a warning on MIPS TX49xx, Atari and presuambly other
      platforms when the driver is built-in but NETDEV_LEGACY_INIT is
      disabled:
      
      drivers/net/ethernet/8390/ne.c:909:20: warning: ‘ne_add_devices’ defined but not used [-Wunused-function]
      
      Merge the two module init functions into a single one with an
      IS_ENABLED() check to replace the incorrect #ifdef.
      
      Fixes: 4228c394
      
       ("make legacy ISA probe optional")
      Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
      Tested-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d7e203ff
    • David S. Miller's avatar
      Merge tag 'mlx5-fixes-2021-09-07' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux · c324f023
      David S. Miller authored
      
      
      Saeed Mahameed says:
      
      ====================
      mlx5 fixes 2021-09-07
      
      This series introduces some fixes to mlx5 driver.
      Please pull and let me know if there is any problem.
      
      Included here, a patch which solves a build warning reported on
      linux-kernel mailing list [1]:
      Fix commit ("net/mlx5: Bridge, fix uninitialized variable usage")
      
      I hope this series can make it to rc1.
      
      [1] https://www.spinics.net/lists/netdev/msg765481.html
      ====================
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c324f023
    • Sukadev Bhattiprolu's avatar
      ibmvnic: check failover_pending in login response · d437f5aa
      Sukadev Bhattiprolu authored
      
      
      If a failover occurs before a login response is received, the login
      response buffer maybe undefined. Check that there was no failover
      before accessing the login response buffer.
      
      Signed-off-by: default avatarSukadev Bhattiprolu <sukadev@linux.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d437f5aa
    • Jeremy Kerr's avatar
      mctp: perform route destruction under RCU read lock · 581edcd0
      Jeremy Kerr authored
      
      
      The kernel test robot reports:
      
        [  843.509974][  T345] =============================
        [  843.524220][  T345] WARNING: suspicious RCU usage
        [  843.538791][  T345] 5.14.0-rc2-00606-g889b7da23abf #1 Not tainted
        [  843.553617][  T345] -----------------------------
        [  843.567412][  T345] net/mctp/route.c:310 RCU-list traversed in non-reader section!!
      
      - we're missing the rcu read lock acquire around the destruction path.
      
      This change adds the acquire/release - the path is already atomic, and
      we're using the _rcu list iterators.
      
      Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
      Signed-off-by: default avatarJeremy Kerr <jk@codeconstruct.com.au>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      581edcd0
    • Lin, Zhenpeng's avatar
      dccp: don't duplicate ccid when cloning dccp sock · d9ea761f
      Lin, Zhenpeng authored
      Commit 2677d206 ("dccp: don't free ccid2_hc_tx_sock ...") fixed
      a UAF but reintroduced CVE-2017-6074.
      
      When the sock is cloned, two dccps_hc_tx_ccid will reference to the
      same ccid. So one can free the ccid object twice from two socks after
      cloning.
      
      This issue was found by "Hadar Manor" as well and assigned with
      CVE-2020-16119, which was fixed in Ubuntu's kernel. So here I port
      the patch from Ubuntu to fix it.
      
      The patch prevents cloned socks from referencing the same ccid.
      
      Fixes: 2677d206
      
       ("dccp: don't free ccid2_hc_tx_sock ...")
      Signed-off-by: default avatarZhenpeng Lin <zplin@psu.edu>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d9ea761f
    • Samuel Holland's avatar
      dt-bindings: net: sun8i-emac: Add compatible for D1 · 0f31ab21
      Samuel Holland authored
      
      
      The D1 SoC contains EMAC hardware which is compatible with the A64 EMAC.
      Add the new compatible string, with the A64 as a fallback.
      
      Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
      Acked-by: default avatarMaxime Ripard <maxime@cerno.tech>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0f31ab21
    • Aya Levin's avatar
      net/mlx5e: Fix condition when retrieving PTP-rqn · 8db6a54f
      Aya Levin authored
      When activating the PTP-RQ, redirect the RQT from drop-RQ to PTP-RQ.
      Use mlx5e_channels_get_ptp_rqn to retrieve the rqn. This helper returns
      a boolean (not status), hence caller should consider return value 0 as a
      fail. Change the caller interpretation of the return value.
      
      Fixes: 43ec0f41
      
       ("net/mlx5e: Hide all implementation details of mlx5e_rx_res")
      Signed-off-by: default avatarAya Levin <ayal@nvidia.com>
      Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
      Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
      8db6a54f
    • Aya Levin's avatar
      net/mlx5e: Fix mutual exclusion between CQE compression and HW TS · c91c1da7
      Aya Levin authored
      Some profiles of the driver don't support a dedicated PTP-RQ, hence can't
      support HW TS and CQE compression simultaneously. When HW TS is enabled
      the COE compression is disabled, and should be restored when the HW TS
      is turned off. Add rx_filter as an input to modifying CQE compression to
      enforce this restriction.
      
      Fixes: 256f79d1
      
       ("net/mlx5e: Fix HW TS with CQE compression according to profile")
      Signed-off-by: default avatarAya Levin <ayal@nvidia.com>
      Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
      Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
      c91c1da7
    • Maor Gottlieb's avatar
      net/mlx5: Fix potential sleeping in atomic context · ee27e330
      Maor Gottlieb authored
      Fixes the below flow of sleeping in atomic context by releasing
      the RCU lock before calling to free_match_list.
      
      build_match_list() <- disables preempt
      -> free_match_list()
         -> tree_put_node()
            -> down_write_ref_node() <- take write lock
      
      Fixes: 693c6883
      
       ("net/mlx5: Add hash table for flow groups in flow table")
      Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarMaor Gottlieb <maorg@nvidia.com>
      Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
      ee27e330
    • Saeed Mahameed's avatar
      net/mlx5: FWTrace, cancel work on alloc pd error flow · dfe6fd72
      Saeed Mahameed authored
      Handle error flow on mlx5_core_alloc_pd() failure,
      read_fw_strings_work must be canceled.
      
      Fixes: c71ad41c
      
       ("net/mlx5: FW tracer, events handling")
      Reported-by: default avatarPavel Machek (CIP) <pavel@denx.de>
      Suggested-by: default avatarPavel Machek (CIP) <pavel@denx.de>
      Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
      Reviewed-by: default avatarAya Levin <ayal@nvidia.com>
      dfe6fd72
    • Mark Bloch's avatar
      net/mlx5: Lag, don't update lag if lag isn't supported · da8252d5
      Mark Bloch authored
      In NICs that don't support LAG, the LAG control structure won't be
      allocated. If it wasn't allocated it means LAG doesn't exists and can be
      skipped.
      
      Fixes: cac1eb2c
      
       ("net/mlx5: Lag, properly lock eswitch if needed")
      Signed-off-by: default avatarMark Bloch <mbloch@nvidia.com>
      Reviewed-by: default avatarMaor Gottlieb <maorg@nvidia.com>
      Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
      da8252d5
    • Parav Pandit's avatar
      net/mlx5: Fix rdma aux device on devlink reload · 897ae4b4
      Parav Pandit authored
      RDMA auxdev parameter registration was skipped for eswitch manager PCI PF.
      Due to this when devlink parameter is read, it reads as false in below
      code flow.
      
      $ devlink dev reload pci/0000:06:00.0
        devlink_reload()
          mlx5_load_one()
            mlx5_attach_device()
              is_ib_enabled()
                devlink_param_driverinit_value_get()
      
      Due to this, is_ib_enabled() returns false for the RDMA auxiliary
      device. This results into a skipping RDMA auxiliary device creation on
      reload.
      
      There is no need to check for eswitch manager capability to support RDMA
      auxiliary device. Hence, fix it by skipping eswitch manager capability.
      
      Fixes: 87158ced
      
       ("net/mlx5: Support enable_rdma devlink dev param")
      Signed-off-by: default avatarParav Pandit <parav@nvidia.com>
      Reviewed-by: default avatarShay Drory <shayd@nvidia.com>
      Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
      897ae4b4
    • Vlad Buslov's avatar
      net/mlx5: Bridge, fix uninitialized variable usage · 8343268e
      Vlad Buslov authored
      
      
      In some conditions variable 'err' is not assigned with value in
      mlx5_esw_bridge_port_obj_attr_set() and mlx5_esw_bridge_port_changeupper()
      functions after recent changes to support LAG. Initialize the variable with
      zero value in both cases.
      
      Reported-by: default avatarColin King <colin.king@canonical.com>
      Reported-by: default avatarTim Gardner <tim.gardner@canonical.com>
      Reported-by: default avatarNaresh Kamboju <naresh.kamboju@linaro.org>
      CC: linux-kernel@vger.kernel.org
      Fixes: ff9b7521
      
       ("net/mlx5: Bridge, support LAG")
      Signed-off-by: default avatarVlad Buslov <vladbu@nvidia.com>
      8343268e
    • Linus Torvalds's avatar
      Merge tag 'net-5.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 626bf91a
      Linus Torvalds authored
      Pull networking fixes and stragglers from Jakub Kicinski:
       "Networking stragglers and fixes, including changes from netfilter,
        wireless and can.
      
        Current release - regressions:
      
         - qrtr: revert check in qrtr_endpoint_post(), fixes audio and wifi
      
         - ip_gre: validate csum_start only on pull
      
         - bnxt_en: fix 64-bit doorbell operation on 32-bit kernels
      
         - ionic: fix double use of queue-lock, fix a sleeping in atomic
      
         - can: c_can: fix null-ptr-deref on ioctl()
      
         - cs89x0: disable compile testing on powerpc
      
        Current release - new code bugs:
      
         - bridge: mcast: fix vlan port router deadlock, consistently disable
           BH
      
        Previous releases - regressions:
      
         - dsa: tag_rtl4_a: fix egress tags, only port 0 was working
      
         - mptcp: fix possible divide by zero
      
         - netfilter: nft_ct: protect nft_ct_pcpu_template_refcnt with mutex
      
         - netfilter: socket: icmp6: fix use-after-scope
      
         - stmmac: fix MAC not working when system resume back with WoL active
      
        Previous releases - always broken:
      
         - ip/ip6_gre: use the same logic as SIT interfaces when computing
           v6LL address
      
         - seg6: set fc_nlinfo in nh_create_ipv4, nh_create_ipv6
      
         - mptcp: only send extra TCP acks in eligible socket states
      
         - dsa: lantiq_gswip: fix maximum frame length
      
         - stmmac: fix overall budget calculation for rxtx_napi
      
         - bnxt_en: fix firmware version reporting via devlink
      
         - renesas: sh_eth: add missing barrier to fix freeing wrong tx
           descriptor
      
        Stragglers:
      
         - netfilter: conntrack: switch to siphash
      
         - netfilter: refuse insertion if chain has grown too large
      
         - ncsi: add get MAC address command to get Intel i210 MAC address"
      
      * tag 'net-5.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (76 commits)
        ieee802154: Remove redundant initialization of variable ret
        net: stmmac: fix MAC not working when system resume back with WoL active
        net: phylink: add suspend/resume support
        net: renesas: sh_eth: Fix freeing wrong tx descriptor
        bonding: 3ad: pass parameter bond_params by reference
        cxgb3: fix oops on module removal
        can: c_can: fix null-ptr-deref on ioctl()
        can: rcar_canfd: add __maybe_unused annotation to silence warning
        net: wwan: iosm: Unify IO accessors used in the driver
        net: wwan: iosm: Replace io.*64_lo_hi() with regular accessors
        net: qcom/emac: Replace strlcpy with strscpy
        ip6_gre: Revert "ip6_gre: add validation for csum_start"
        net: hns3: make hclgevf_cmd_caps_bit_map0 and hclge_cmd_caps_bit_map0 static
        selftests/bpf: Test XDP bonding nest and unwind
        bonding: Fix negative jump label count on nested bonding
        MAINTAINERS: add VM SOCKETS (AF_VSOCK) entry
        stmmac: dwmac-loongson:Fix missing return value
        iwlwifi: fix printk format warnings in uefi.c
        net: create netdev->dev_addr assignment helpers
        bnxt_en: Fix possible unintended driver initiated error recovery
        ...
      626bf91a
    • Linus Torvalds's avatar
      Merge tag 'linux-watchdog-5.15-rc1' of git://www.linux-watchdog.org/linux-watchdog · 4c00e1e2
      Linus Torvalds authored
      Pull watchdog updates from Wim Van Sebroeck:
      
       - add Mediatek MT7986 & MT8195 wdt support
      
       - add Maxim MAX63xx
      
       - drop bd70528 support
      
       - rewrite ixp4xx to watchdog framework
      
       - constify static struct watchdog_ops for sl28cpld_wdt, mpc8xxx_wdt and
         tqmx86
      
       - introduce watchdog_dev_suspend/resume
      
       - several fixes and improvements
      
      * tag 'linux-watchdog-5.15-rc1' of git://www.linux-watchdog.org/linux-watchdog:
        dt-bindings: watchdog: Add compatible for Mediatek MT7986
        watchdog: ixp4xx: Rewrite driver to use core
        watchdog: Start watchdog in watchdog_set_last_hw_keepalive only if appropriate
        watchdog: max63xx_wdt: Add device tree probing
        dt-bindings: watchdog: Add Maxim MAX63xx bindings
        watchdog: mediatek: mt8195: add wdt support
        dt-bindings: reset: mt8195: add toprgu reset-controller header file
        watchdog: tqmx86: Constify static struct watchdog_ops
        watchdog: mpc8xxx_wdt: Constify static struct watchdog_ops
        watchdog: sl28cpld_wdt: Constify static struct watchdog_ops
        watchdog: iTCO_wdt: Fix detection of SMI-off case
        watchdog: bcm2835_wdt: consider system-power-controller property
        watchdog: imx2_wdg: notify wdog core to stop ping worker on suspend
        watchdog: introduce watchdog_dev_suspend/resume
        watchdog: Fix NULL pointer dereference when releasing cdev
        watchdog: only run driver set_pretimeout op if device supports it
        watchdog: bd70528 drop bd70528 support
      4c00e1e2
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · 192ad3c2
      Linus Torvalds authored
      Pull KVM updates from Paolo Bonzini:
       "ARM:
         - Page ownership tracking between host EL1 and EL2
         - Rely on userspace page tables to create large stage-2 mappings
         - Fix incompatibility between pKVM and kmemleak
         - Fix the PMU reset state, and improve the performance of the virtual
           PMU
         - Move over to the generic KVM entry code
         - Address PSCI reset issues w.r.t. save/restore
         - Preliminary rework for the upcoming pKVM fixed feature
         - A bunch of MM cleanups
         - a vGIC fix for timer spurious interrupts
         - Various cleanups
      
        s390:
         - enable interpretation of specification exceptions
         - fix a vcpu_idx vs vcpu_id mixup
      
        x86:
         - fast (lockless) page fault support for the new MMU
         - new MMU now the default
         - increased maximum allowed VCPU count
         - allow inhibit IRQs on KVM_RUN while debugging guests
         - let Hyper-V-enabled guests run with virtualized LAPIC as long as
           they do not enable the Hyper-V "AutoEOI" feature
         - fixes and optimizations for the toggling of AMD AVIC (virtualized
           LAPIC)
         - tuning for the case when two-dimensional paging (EPT/NPT) is
           disabled
         - bugfixes and cleanups, especially with respect to vCPU reset and
           choosing a paging mode based on CR0/CR4/EFER
         - support for 5-level page table on AMD processors
      
        Generic:
         - MMU notifier invalidation callbacks do not take mmu_lock unless
           necessary
         - improved caching of LRU kvm_memory_slot
         - support for histogram statistics
         - add statistics for halt polling and remote TLB flush requests"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm: (210 commits)
        KVM: Drop unused kvm_dirty_gfn_invalid()
        KVM: x86: Update vCPU's hv_clock before back to guest when tsc_offset is adjusted
        KVM: MMU: mark role_regs and role accessors as maybe unused
        KVM: MIPS: Remove a "set but not used" variable
        x86/kvm: Don't enable IRQ when IRQ enabled in kvm_wait
        KVM: stats: Add VM stat for remote tlb flush requests
        KVM: Remove unnecessary export of kvm_{inc,dec}_notifier_count()
        KVM: x86/mmu: Move lpage_disallowed_link further "down" in kvm_mmu_page
        KVM: x86/mmu: Relocate kvm_mmu_page.tdp_mmu_page for better cache locality
        Revert "KVM: x86: mmu: Add guest physical address check in translate_gpa()"
        KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page
        kvm: x86: Increase KVM_SOFT_MAX_VCPUS to 710
        kvm: x86: Increase MAX_VCPUS to 1024
        kvm: x86: Set KVM_MAX_VCPU_ID to 4*KVM_MAX_VCPUS
        KVM: VMX: avoid running vmx_handle_exit_irqoff in case of emulation
        KVM: x86/mmu: Don't freak out if pml5_root is NULL on 4-level host
        KVM: s390: index kvm->arch.idle_mask by vcpu_idx
        KVM: s390: Enable specification exception interpretation
        KVM: arm64: Trim guest debug exception handling
        KVM: SVM: Add 5-level page table support for SVM
        ...
      192ad3c2
    • Linus Torvalds's avatar
      Merge branch 'dmi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging · a2b28235
      Linus Torvalds authored
      Pull dmi fix from Jean Delvare.
      
      Unbreak some existing udev/hwdb modalias matches due to misplaced
      product_sku field.
      
      * 'dmi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging:
        firmware: dmi: Move product_sku info to the end of the modalias
      a2b28235
    • Linus Torvalds's avatar
      Merge tag 'ntb-5.15' of git://github.com/jonmason/ntb · 1735715e
      Linus Torvalds authored
      Pull NTB updates from Jon Mason:
       "Bug fixes and clean-ups for Linux v5.15"
      
      * tag 'ntb-5.15' of git://github.com/jonmason/ntb:
        NTB: switch from 'pci_' to 'dma_' API
        ntb: ntb_pingpong: remove redundant initialization of variables msg_data and spad_data
        NTB: perf: Fix an error code in perf_setup_inbuf()
        NTB: Fix an error code in ntb_msit_probe()
        ntb: intel: remove invalid email address in header comment
      1735715e
    • Linus Torvalds's avatar
      Merge tag 'rproc-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc · 21f577b0
      Linus Torvalds authored
      Pull remoteproc updates from Bjorn Andersson:
      
       - move the crash recovery worker to the freezable work queue to avoid
         interaction with other drivers during suspend & resume
      
       - fix a couple of typos in comments
      
       - add support for handling the audio DSP on SDM660
      
       - fix a race between the Qualcomm wireless subsystem driver and the
         associated driver for the RF chip
      
      * tag 'rproc-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc:
        remoteproc: q6v5_pas: Add sdm660 ADSP PIL compatible
        dt-bindings: remoteproc: qcom: adsp: Add SDM660 ADSP
        remoteproc: use freezable workqueue for crash notifications
        remoteproc: fix kernel doc for struct rproc_ops
        remoteproc: fix an typo in fw_elf_get_class code comments
        remoteproc: qcom: wcnss: Fix race with iris probe
      21f577b0
    • Linus Torvalds's avatar
      Merge tag 'backlight-next-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight · 2d7b4cdb
      Linus Torvalds authored
      Pull backlight updates from Lee Jones:
       "Fix-ups:
         - Improve bootloader/kernel device handover
      
        Bug Fixes:
         - Stabilise backlight in ktd253 driver"
      
      * tag 'backlight-next-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight:
        backlight: pwm_bl: Improve bootloader/kernel device handover
        backlight: ktd253: Stabilize backlight
      2d7b4cdb
    • Linus Torvalds's avatar
      Merge tag 'mfd-next-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd · 86406a9e
      Linus Torvalds authored
      Pull MFD updates from Lee Jones:
       "Core Frameworks:
         - Add support for registering devices via MFD cells to Simple MFD (I2C)
      
        New Drivers:
         - Add support for Renesas Synchronization Management Unit (SMU)
      
        New Device Support:
         - Add support for N5010 to Intel M10 BMC
         - Add support for Cannon Lake to Intel LPSS ACPI
         - Add support for Samsung SSG{1,2} to ST-Ericsson's U8500 family
         - Add support for TQMx110EB and TQMxE40x to TQ-Systems PLD TQMx86
      
        New Functionality:
         - Add support for GPIO to Intel LPC ICH
         - Add support for Reset to Texas Instruments TPS65086
      
        Fix-ups:
         - Trivial, sorting, whitespace, renaming, etc; mt6360-core, db8500-prcmu-regs, tqmx86
         - Device Tree fiddling; syscon, axp20x, qcom,pm8008, ti,tps65086, brcm,cru
         - Use proper APIs for IRQ map resolution; ab8500-core, stmpe, tc3589x, wm8994-irq
         - Pass 'supplied-from' property through axp288_fuel_gauge via swnode
         - Remove unused file entry; MAINTAINERS
         - Make interrupt line optional; tps65086
         - Rename db8500-cpuidle driver symbol; db8500-prcmu
         - Remove support for unused hardware; tqmx86
         - Provide a standard LPC clock frequency for unknown boards; tqmx86
         - Remove unused code; ti_am335x_tscadc
         - Use of_iomap() instead of ioremap(); syscon
      
        Bug Fixes:
         - Clear GPIO IRQ resource flags when no IRQ is set; tqmx86
         - Fix incorrect/misleading frequencies; db8500-prcmu
         - Mitigate namespace clash with other GPIOBASE users"
      
      * tag 'mfd-next-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd: (31 commits)
        mfd: lpc_sch: Rename GPIOBASE to prevent build error
        mfd: syscon: Use of_iomap() instead of ioremap()
        dt-bindings: mfd: Add Broadcom CRU
        mfd: ti_am335x_tscadc: Delete superfluous error message
        mfd: tqmx86: Assume 24MHz LPC clock for unknown boards
        mfd: tqmx86: Add support for TQ-Systems DMI IDs
        mfd: tqmx86: Add support for TQMx110EB and TQMxE40x
        mfd: tqmx86: Fix typo in "platform"
        mfd: tqmx86: Remove incorrect TQMx90UC board ID
        mfd: tqmx86: Clear GPIO IRQ resource when no IRQ is set
        mfd: simple-mfd-i2c: Add support for registering devices via MFD cells
        mfd/cpuidle: ux500: Rename driver symbol
        mfd: tps65086: Add cell entry for reset driver
        mfd: tps65086: Make interrupt line optional
        dt-bindings: mfd: Convert tps65086.txt to YAML
        MAINTAINERS: Adjust ARM/NOMADIK/Ux500 ARCHITECTURES to file renaming
        mfd: db8500-prcmu: Handle missing FW variant
        mfd: db8500-prcmu: Rename register header
        mfd: axp20x: Add supplied-from property to axp288_fuel_gauge cell
        mfd: Don't use irq_create_mapping() to resolve a mapping
        ...
      86406a9e
    • Linus Torvalds's avatar
      Merge tag 'gpio-updates-for-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux · 5e6a5845
      Linus Torvalds authored
      Pull gpio updates from Bartosz Golaszewski:
       "We mostly have various improvements and refactoring all over the place
        but also some interesting new features - like the virtio GPIO driver
        that allows guest VMs to use host's GPIOs. We also have a new/old GPIO
        driver for rockchip - this one has been split out of the pinctrl
        driver.
      
        Summary:
      
         - new driver: gpio-virtio allowing a guest VM running linux to access
           GPIO lines provided by the host
      
         - split the GPIO driver out of the rockchip pin control driver
      
         - add support for a new model to gpio-aspeed-sgpio, refactor the
           driver and use generic device property interfaces, improve property
           sanitization
      
         - add ACPI support to gpio-tegra186
      
         - improve the code setting the line names to support multiple GPIO
           banks per device
      
         - constify a bunch of OF functions in the core GPIO code and make the
           declaration for one of the core OF functions we use consistent
           within its header
      
         - use software nodes in intel_quark_i2c_gpio
      
         - add support for the gpio-line-names property in gpio-mt7621
      
         - use the standard GPIO function for setting the GPIO names in
           gpio-brcmstb
      
         - fix a bunch of leaks and other bugs in gpio-mpc8xxx
      
         - use generic pm callbacks in gpio-ml-ioh
      
         - improve resource management and PM handling in gpio-mlxbf2
      
         - modernize and improve the gpio-dwapb driver
      
         - coding style improvements in gpio-rcar
      
         - documentation fixes and improvements
      
         - update the MAINTAINERS entry for gpio-zynq
      
         - minor tweaks in several drivers"
      
      * tag 'gpio-updates-for-v5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux: (35 commits)
        gpio: mpc8xxx: Use 'devm_gpiochip_add_data()' to simplify the code and avoid a leak
        gpio: mpc8xxx: Fix a potential double iounmap call in 'mpc8xxx_probe()'
        gpio: mpc8xxx: Fix a resources leak in the error handling path of 'mpc8xxx_probe()'
        gpio: viperboard: remove platform_set_drvdata() call in probe
        gpio: virtio: Add missing mailings lists in MAINTAINERS entry
        gpio: virtio: Fix sparse warnings
        gpio: remove the obsolete MX35 3DS BOARD MC9S08DZ60 GPIO functions
        gpio: max730x: Use the right include
        gpio: Add virtio-gpio driver
        gpio: mlxbf2: Use DEFINE_RES_MEM_NAMED() helper macro
        gpio: mlxbf2: Use devm_platform_ioremap_resource()
        gpio: mlxbf2: Drop wrong use of ACPI_PTR()
        gpio: mlxbf2: Convert to device PM ops
        gpio: dwapb: Get rid of legacy platform data
        mfd: intel_quark_i2c_gpio: Convert GPIO to use software nodes
        gpio: dwapb: Read GPIO base from gpio-base property
        gpio: dwapb: Unify ACPI enumeration checks in get_irq() and configure_irqs()
        gpiolib: Deduplicate forward declaration in the consumer.h header
        MAINTAINERS: update gpio-zynq.yaml reference
        gpio: tegra186: Add ACPI support
        ...
      5e6a5845
    • Linus Torvalds's avatar
      Merge tag 'fuse-update-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse · 75b96f0e
      Linus Torvalds authored
      Pull fuse updates from Miklos Szeredi:
      
       - Allow mounting an active fuse device. Previously the fuse device
         would always be mounted during initialization, and sharing a fuse
         superblock was only possible through mount or namespace cloning
      
       - Fix data flushing in syncfs (virtiofs only)
      
       - Fix data flushing in copy_file_range()
      
       - Fix a possible deadlock in atomic O_TRUNC
      
       - Misc fixes and cleanups
      
      * tag 'fuse-update-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse:
        fuse: remove unused arg in fuse_write_file_get()
        fuse: wait for writepages in syncfs
        fuse: flush extending writes
        fuse: truncate pagecache on atomic_o_trunc
        fuse: allow sharing existing sb
        fuse: move fget() to fuse_get_tree()
        fuse: move option checking into fuse_fill_super()
        fuse: name fs_context consistently
        fuse: fix use after free in fuse_read_interrupt()
      75b96f0e
    • Linus Torvalds's avatar
      Merge tag 'kgdb-5.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/danielt/linux · 996fe061
      Linus Torvalds authored
      Pull kgdb updates from Daniel Thompson:
       "Changes for kgdb/kdb this cycle are dominated by a change from Sumit
        that removes as small (256K) private heap from kdb. This is change
        I've hoped for ever since I discovered how few users of this heap
        remained in the kernel, so many thanks to Sumit for hunting these
        down.
      
        The other change is an incremental step towards SPDX headers"
      
      * tag 'kgdb-5.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/danielt/linux:
        kernel: debug: Convert to SPDX identifier
        kdb: Rename members of struct kdbtab_t
        kdb: Simplify kdb_defcmd macro logic
        kdb: Get rid of redundant kdb_register_flags()
        kdb: Rename struct defcmd_set to struct kdb_macro
        kdb: Get rid of custom debug heap allocator
      996fe061
    • Linus Torvalds's avatar
      Revert "memcg: enable accounting for pollfd and select bits arrays" · 0bcfe68b
      Linus Torvalds authored
      This reverts commit b6558434
      
      .
      
      Just like with the memcg lock accounting, the kernel test robot reports
      a sizeable performance regression for this commit, and while it clearly
      does the rigth thing in theory, we'll need to look at just how to avoid
      or minimize the performance overhead of the memcg accounting.
      
      People already have suggestions on how to do that, but it's "future
      work".
      
      So revert it for now.
      
      [ Note: the first link below is for this same commit but a different
        commit ID, because it's the kernel test robot ended up noticing it in
        Andrew Morton's patch queue ]
      
      Link: https://lore.kernel.org/lkml/20210905132732.GC15026@xsang-OptiPlex-9020/
      Link: https://lore.kernel.org/lkml/20210907150757.GE17617@xsang-OptiPlex-9020/
      Acked-by: default avatarJens Axboe <axboe@kernel.dk>
      Acked-by: default avatarShakeel Butt <shakeelb@google.com>
      Acked-by: default avatarRoman Gushchin <guro@fb.com>
      Cc: Tejun Heo <tj@kernel.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      0bcfe68b
    • Linus Torvalds's avatar
      Revert "memcg: enable accounting for file lock caches" · 3754707b
      Linus Torvalds authored
      This reverts commit 0f12156d
      
      .
      
      The kernel test robot reports a sizeable performance regression for this
      commit, and while it clearly does the rigth thing in theory, we'll need
      to look at just how to avoid or minimize the performance overhead of the
      memcg accounting.
      
      People already have suggestions on how to do that, but it's "future
      work".
      
      So revert it for now.
      
      Link: https://lore.kernel.org/lkml/20210907150757.GE17617@xsang-OptiPlex-9020/
      Acked-by: default avatarJens Axboe <axboe@kernel.dk>
      Acked-by: default avatarShakeel Butt <shakeelb@google.com>
      Acked-by: default avatarRoman Gushchin <guro@fb.com>
      Cc: Tejun Heo <tj@kernel.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      3754707b
    • Linus Torvalds's avatar
      Revert "mm/gup: remove try_get_page(), call try_get_compound_head() directly" · cd1adf1b
      Linus Torvalds authored
      This reverts commit 9857a17f
      
      .
      
      That commit was completely broken, and I should have caught on to it
      earlier.  But happily, the kernel test robot noticed the breakage fairly
      quickly.
      
      The breakage is because "try_get_page()" is about avoiding the page
      reference count overflow case, but is otherwise the exact same as a
      plain "get_page()".
      
      In contrast, "try_get_compound_head()" is an entirely different beast,
      and uses __page_cache_add_speculative() because it's not just about the
      page reference count, but also about possibly racing with the underlying
      page going away.
      
      So all the commentary about how
      
       "try_get_page() has fallen a little behind in terms of maintenance,
        try_get_compound_head() handles speculative page references more
        thoroughly"
      
      was just completely wrong: yes, try_get_compound_head() handles
      speculative page references, but the point is that try_get_page() does
      not, and must not.
      
      So there's no lack of maintainance - there are fundamentally different
      semantics.
      
      A speculative page reference would be entirely wrong in "get_page()",
      and it's entirely wrong in "try_get_page()".  It's not about
      speculation, it's purely about "uhhuh, you can't get this page because
      you've tried to increment the reference count too much already".
      
      The reason the kernel test robot noticed this bug was that it hit the
      VM_BUG_ON() in __page_cache_add_speculative(), which is all about
      verifying that the context of any speculative page access is correct.
      But since that isn't what try_get_page() is all about, the VM_BUG_ON()
      tests things that are not correct to test for try_get_page().
      
      Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
      Cc: John Hubbard <jhubbard@nvidia.com>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      cd1adf1b
  3. Sep 07, 2021
    • Colin Ian King's avatar
      ieee802154: Remove redundant initialization of variable ret · 0f77f2de
      Colin Ian King authored
      
      
      The variable ret is being initialized with a value that is never read, it
      is being updated later on. The assignment is redundant and can be removed.
      
      Addresses-Coverity: ("Unused value")
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0f77f2de
    • David S. Miller's avatar
      Merge branch 'stmmac-wol-fix' · d1bf7338
      David S. Miller authored
      
      
      Joakim Zhang says:
      
      ====================
      net: stmmac: fix WoL issue
      
      This patch set fixes stmmac not working after system resume back with WoL
      active. Thanks a lot for Russell King keeps looking into this issue.
      ====================
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d1bf7338
    • Joakim Zhang's avatar
      net: stmmac: fix MAC not working when system resume back with WoL active · 90702dcd
      Joakim Zhang authored
      We can reproduce this issue with below steps:
      1) enable WoL on the host
      2) host system suspended
      3) remote client send out wakeup packets
      We can see that host system resume back, but can't work, such as ping failed.
      
      After a bit digging, this issue is introduced by the commit 46f69ded
      ("net: stmmac: Use resolved link config in mac_link_up()"), which use
      the finalised link parameters in mac_link_up() rather than the
      parameters in mac_config().
      
      There are two scenarios for MAC suspend/resume in STMMAC driver:
      
      1) MAC suspend with WoL inactive, stmmac_suspend() call
      phylink_mac_change() to notify phylink machine that a change in MAC
      state, then .mac_link_down callback would be invoked. Further, it will
      call phylink_stop() to stop the phylink instance. When MAC resume back,
      firstly phylink_start() is called to start the phylink instance, then
      call phylink_mac_change() which will finally trigger phylink machine to
      invoke .mac_config and .mac_link_up callback. All is fine since
      configuration in these two callbacks will be initialized, that means MAC
      can restore the state.
      
      2) MAC suspend with WoL active, phylink_mac_change() will put link
      down, but there is no phylink_stop() to stop the phylink instance, so it
      will link up again, that means .mac_config and .mac_link_up would be
      invoked before system suspended. After system resume back, it will do
      DMA initialization and SW reset which let MAC lost the hardware setting
      (i.e MAC_Configuration register(offset 0x0) is reset). Since link is up
      before system suspended, so .mac_link_up would not be invoked after
      system resume back, lead to there is no chance to initialize the
      configuration in .mac_link_up callback, as a result, MAC can't work any
      longer.
      
      After discussed with Russell King [1], we confirm that phylink framework
      have not take WoL into consideration yet. This patch calls
      phylink_suspend()/phylink_resume() functions which is newly introduced
      by Russell King to fix this issue.
      
      [1] https://lore.kernel.org/netdev/20210901090228.11308-1-qiangqing.zhang@nxp.com/
      
      Fixes: 46f69ded
      
       ("net: stmmac: Use resolved link config in mac_link_up()")
      Signed-off-by: default avatarJoakim Zhang <qiangqing.zhang@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      90702dcd
    • Russell King (Oracle)'s avatar
      net: phylink: add suspend/resume support · f9749365
      Russell King (Oracle) authored
      
      
      Joakim Zhang reports that Wake-on-Lan with the stmmac ethernet driver broke
      when moving the incorrect handling of mac link state out of mac_config().
      This reason this breaks is because the stmmac's WoL is handled by the MAC
      rather than the PHY, and phylink doesn't cater for that scenario.
      
      This patch adds the necessary phylink code to handle suspend/resume events
      according to whether the MAC still needs a valid link or not. This is the
      barest minimum for this support.
      
      Reported-by: default avatarJoakim Zhang <qiangqing.zhang@nxp.com>
      Tested-by: default avatarJoakim Zhang <qiangqing.zhang@nxp.com>
      Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
      Signed-off-by: default avatarJoakim Zhang <qiangqing.zhang@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f9749365
    • Yoshihiro Shimoda's avatar
      net: renesas: sh_eth: Fix freeing wrong tx descriptor · 0341d5e3
      Yoshihiro Shimoda authored
      The cur_tx counter must be incremented after TACT bit of
      txdesc->status was set. However, a CPU is possible to reorder
      instructions and/or memory accesses between cur_tx and
      txdesc->status. And then, if TX interrupt happened at such a
      timing, the sh_eth_tx_free() may free the descriptor wrongly.
      So, add wmb() before cur_tx++.
      Otherwise NETDEV WATCHDOG timeout is possible to happen.
      
      Fixes: 86a74ff2
      
       ("net: sh_eth: add support for Renesas SuperH Ethernet")
      Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0341d5e3
    • Colin Ian King's avatar
      bonding: 3ad: pass parameter bond_params by reference · bbef56d8
      Colin Ian King authored
      
      
      The parameter bond_params is a relatively large 192 byte sized
      struct so pass it by reference rather than by value to reduce
      copying.
      
      Addresses-Coverity: ("Big parameter passed by value")
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bbef56d8
    • David S. Miller's avatar
      Merge tag 'linux-can-fixes-for-5.15-20210907' of... · 1c990729
      David S. Miller authored
      
      Merge tag 'linux-can-fixes-for-5.15-20210907' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can
      
      linux-can-fixes-for-5.15-20210907
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1c990729
    • David S. Miller's avatar
      Merge tag 'wireless-drivers-2021-09-07' of... · 8f110f35
      David S. Miller authored
      Merge tag 'wireless-drivers-2021-09-07' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers
      
      Kalle Valo says:
      
      ====================
      wireless-drivers fixes for v5.15
      
      First set of fixes for v5.15 and only iwlwifi patches this time. Most
      important being support for new hardware and new firmware API.
      
      I had already earlier applied a fix which also Linus applied to this
      tree as commit 1476ff21
      
       ("iwl: fix debug printf format strings"),
      but this doesn't seem to cause any conflicts so I left it there.
      
      iwlwifi
      
      * add support for firmware API 66
      
      * add support for Samsung Galaxy Book Flex2 Alpha
      
      * fix a leak happening every time module is loaded
      
      * fix a printk compiler warning
      ====================
      
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8f110f35