Skip to content
Commit f5b51f85 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Greg Kroah-Hartman
Browse files

rtc: mc146818: Dont test for bit 0-5 in Register D



[ Upstream commit ebb22a05 ]

The recent change to validate the RTC turned out to be overly tight.

While it cures the problem on the reporters machine it breaks machines
with Intel chipsets which use bit 0-5 of the D register. So check only
for bit 6 being 0 which is the case on these Intel machines as well.

Fixes: 211e5db1 ("rtc: mc146818: Detect and handle broken RTCs")
Reported-by: default avatarSerge Belyshev <belyshev@depni.sinp.msu.ru>
Reported-by: default avatarDirk Gouders <dirk@gouders.net>
Reported-by: default avatarBorislav Petkov <bp@suse.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarDirk Gouders <dirk@gouders.net>
Tested-by: default avatarLen Brown <len.brown@intel.com>
Tested-by: default avatarBorislav Petkov <bp@suse.de>
Acked-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/87zh0nbnha.fsf@nanos.tec.linutronix.de


Stable-dep-of: cd17420e ("rtc: cmos: avoid UIP when writing alarm time")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 37369723
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment