Skip to content
Commit e9301af3 authored by Marek Behún's avatar Marek Behún Committed by David S. Miller
Browse files

net: sfp: fix PHY discovery for FS SFP-10G-T module

Commit 2f3ce7a5 ("net: sfp: rework the RollBall PHY waiting code")
changed the long wait before accessing RollBall / FS modules into
probing for PHY every 1 second, and trying 25 times.

Wei Lei reports that this does not work correctly on FS modules: when
initializing, they may report values different from 0xffff in PHY ID
registers for some MMDs, causing get_phy_c45_ids() to find some bogus
MMD.

Fix this by adding the module_t_wait member back, and setting it to 4
seconds for FS modules.

Fixes: 2f3ce7a5

 ("net: sfp: rework the RollBall PHY waiting code")
Reported-by: default avatarWei Lei <quic_leiwei@quicinc.com>
Signed-off-by: default avatarMarek Behún <kabel@kernel.org>
Tested-by: default avatarLei Wei <quic_leiwei@quicinc.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3b83fa94
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment