Skip to content
Commit df23c702 authored by Steve French's avatar Steve French Committed by Greg Kroah-Hartman
Browse files

smb3: lower default deferred close timeout to address perf regression



[ Upstream commit 7e0e76d9 ]

Performance tests with large number of threads noted that the change
of the default closetimeo (deferred close timeout between when
close is done by application and when client has to send the close
to the server), to 5 seconds from 1 second, significantly degraded
perf in some cases like this (in the filebench example reported,
the stats show close requests on the wire taking twice as long,
and 50% regression in filebench perf). This is stil configurable
via mount parm closetimeo, but to be safe, decrease default back
to its previous value of 1 second.

Reported-by: default avatarYin Fengwei <fengwei.yin@intel.com>
Reported-by: default avatarkernel test robot <yujie.liu@intel.com>
Link: https://lore.kernel.org/lkml/997614df-10d4-af53-9571-edec36b0e2f3@intel.com/


Fixes: 5efdd912 ("smb3: allow deferred close timeout to be configurable")
Cc: stable@vger.kernel.org # 6.0+
Tested-by: default avatarYin Fengwei <fengwei.yin@intel.com>
Reviewed-by: default avatarPaulo Alcantara (SUSE) <pc@manguebit.com>
Reviewed-by: default avatarShyam Prasad N <sprasad@microsoft.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Stable-dep-of: d19342c6 ("cifs: sanitize paths in cifs_update_super_prepath.")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1d9cad9c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment