Skip to content
Commit d8ccbd21 authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: remove BUG_ON()'s in add_new_free_space()



At add_new_free_space() we have these BUG_ON()'s that are there to deal
with any failure to add free space to the in memory free space cache.
Such failures are mostly -ENOMEM that should be very rare. However there's
no need to have these BUG_ON()'s, we can just return any error to the
caller and all callers and their upper call chain are already dealing with
errors.

So just make add_new_free_space() return any errors, while removing the
BUG_ON()'s, and returning the total amount of added free space to an
optional u64 pointer argument.

Reported-by: default avatar <syzbot+3ba856e07b7127889d8c@syzkaller.appspotmail.com>
Link: https://lore.kernel.org/linux-btrfs/000000000000e9cb8305ff4e8327@google.com/


Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 8dbfc14f
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment