Skip to content
Commit c6607012 authored by Xiyu Yang's avatar Xiyu Yang Committed by Jakub Kicinski
Browse files

net: sched: Fix qdisc_rate_table refcount leak when get tcf_block failed



The reference counting issue happens in one exception handling path of
cbq_change_class(). When failing to get tcf_block, the function forgets
to decrease the refcount of "rtab" increased by qdisc_put_rtab(),
causing a refcount leak.

Fix this issue by jumping to "failure" label when get tcf_block failed.

Fixes: 6529eaba ("net: sched: introduce tcf block infractructure")
Signed-off-by: default avatarXiyu Yang <xiyuyang19@fudan.edu.cn>
Reviewed-by: default avatarCong Wang <cong.wang@bytedance.com>
Link: https://lore.kernel.org/r/1630252681-71588-1-git-send-email-xiyuyang19@fudan.edu.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 19a31d79
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment