Skip to content
Commit bd67b711 authored by Thomas Bogendoerfer's avatar Thomas Bogendoerfer
Browse files

MIPS: kernel: Reserve exception base early to prevent corruption



BMIPS is one of the few platforms that do change the exception base.
After commit 2dcb3964 ("memblock: do not start bottom-up allocations
with kernel_end") we started seeing BMIPS boards fail to boot with the
built-in FDT being corrupted.

Before the cited commit, early allocations would be in the [kernel_end,
RAM_END] range, but after commit they would be within [RAM_START +
PAGE_SIZE, RAM_END].

The custom exception base handler that is installed by
bmips_ebase_setup() done for BMIPS5000 CPUs ends-up trampling on the
memory region allocated by unflatten_and_copy_device_tree() thus
corrupting the FDT used by the kernel.

To fix this, we need to perform an early reservation of the custom
exception space. Additional we reserve the first 4k (1k for R3k) for
either normal exception vector space (legacy CPUs) or special vectors
like cache exceptions.

Huge thanks to Serge for analysing and proposing a solution to this
issue.

Fixes: 2dcb3964 ("memblock: do not start bottom-up allocations with kernel_end")
Reported-by: default avatarKamal Dasu <kdasu.kdev@gmail.com>
Debugged-by: default avatarSerge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: default avatarMike Rapoport <rppt@linux.ibm.com>
Tested-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 6654111c
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment