Skip to content
Commit b648756e authored by Azeem Shaikh's avatar Azeem Shaikh Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Replace all non-returning strlcpy() with strscpy()

[ Upstream commit 37f1663c

 ]

strlcpy() reads the entire source buffer first.  This read may exceed the
destination size limit.  This is both inefficient and can lead to linear
read overflows if a source string is not NUL-terminated [1].  In an effort
to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: default avatarAzeem Shaikh <azeemshaikh38@gmail.com>
Link: https://lore.kernel.org/r/20230516025404.2843867-1-azeemshaikh38@gmail.com
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Stable-dep-of: c3408c4a

 ("scsi: qla2xxx: Avoid possible run-time warning with long model_num")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ecf4ddc3
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment