Skip to content
Commit b3ffbc37 authored by Ruiqiang Hao's avatar Ruiqiang Hao
Browse files

mmc: cavium-thunderx: Drop the IRQF_NO_THREAD constraint



The IRQF_NO_THREAD is added by a Marvell SDK12 patch commit 65549eba
("mmc: octeontx2: fix swiotlb buffer is full") in order to get back some
of the performance loss. But in some cases (such as rt kernel), we need
the capability to thread irq handler. Otherwise we would get following
warnings because the normal spin lock is used in the irq handler. So drop
this constraint.

BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:46
in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 767, name: systemd-udevd
preempt_count: 10002, expected: 0
RCU nest depth: 0, expected: 0
Preemption disabled at:
[<ffff8000082319bc>] create_object.isra.0+0xfc/0x300
CPU: 0 PID: 767 Comm: systemd-udevd Tainted: G        W         5.15.124-rt61-yocto-preempt-rt #2
Hardware name: Marvell OcteonTX CN96XX board (DT)
Call trace:
 dump_backtrace+0x0/0x1c0
 show_stack+0x20/0x30
 dump_stack_lvl+0x68/0x84
 dump_stack+0x18/0x34
 __might_resched+0x154/0x1b0
 rt_spin_lock+0x38/0xd0
 free_iova_fast+0x9c/0x27c
 __iommu_dma_unmap+0x164/0x174
 iommu_dma_unmap_sg+0xb0/0x140
 dma_unmap_sg_attrs+0x30/0x54
 cvm_mmc_interrupt+0x2a4/0x5f0
 __handle_irq_event_percpu+0x64/0x28c
 handle_irq_event_percpu+0x68/0xc0
 handle_irq_event+0x84/0xe0
 handle_fasteoi_irq+0xc4/0x234
 handle_domain_irq+0xa0/0xf0
 gic_handle_irq+0x60/0x154
 call_on_irq_stack+0x20/0x2c
 do_interrupt_handler+0x5c/0x68
 el1_interrupt+0x30/0x80
 el1h_64_irq_handler+0x18/0x24
 el1h_64_irq+0x78/0x7c
 _raw_spin_unlock_irqrestore+0x20/0x6c
 create_object.isra.0+0x19c/0x300
 kmemleak_alloc+0x38/0x4c
 kmem_cache_alloc+0x1e8/0x320
 anon_vma_clone+0x74/0x1e0
 anon_vma_fork+0x34/0x1e0
 dup_mm+0x38c/0x5ac
 copy_process+0x1594/0x16a0
 kernel_clone+0x94/0x490
 __do_sys_clone+0x70/0xac
 __arm64_sys_clone+0x28/0x3c
 invoke_syscall.constprop.0+0x58/0xf0
 do_el0_svc+0x144/0x160
 el0_svc+0x28/0xe0
 el0t_64_sync_handler+0xa4/0x130
 el0t_64_sync+0x1a0/0x1a4

Signed-off-by: default avatarRuiqiang Hao <Ruiqiang.Hao@windriver.com>
parent 53312e92
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment