Skip to content
Commit b3dc3f8e authored by Christoph Hellwig's avatar Christoph Hellwig
Browse files

media: videobuf-dma-contig: use dma_mmap_coherent



dma_alloc_coherent does not return a physical address, but a DMA address,
which might be remapped or have an offset.  Passing the DMA address to
vm_iomap_memory is thus broken.

Use the proper dma_mmap_coherent helper instead, and stop passing
__GFP_COMP to dma_alloc_coherent, as the memory management inside the
DMA allocator is hidden from the callers and does not require it.

With this the gfp_t argument to __videobuf_dc_alloc can be removed and
hard coded to GFP_KERNEL.

Fixes: a8f3c203 ("[media] videobuf-dma-contig: add cache support")
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 8d58aa48
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment