Skip to content
Commit 901d3765 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

KVM: x86: revalidate steal time cache if MSR value changes



Commit 7e2175eb ("KVM: x86: Fix recording of guest steal time
/ preempted status", 2021-11-11) open coded the previous call to
kvm_map_gfn, but in doing so it dropped the comparison between the cached
guest physical address and the one in the MSR.  This cause an incorrect
cache hit if the guest modifies the steal time address while the memslots
remain the same.  This can happen with kexec, in which case the steal
time data is written at the address used by the old kernel instead of
the old one.

While at it, rename the variable from gfn to gpa since it is a plain
physical address and not a right-shifted one.

Reported-by: default avatarDave Young <ruyang@redhat.com>
Reported-by: default avatarXiaoying Yan <yiyan@redhat.com>
Analyzed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Cc: David Woodhouse <dwmw@amazon.co.uk>
Cc: stable@vger.kernel.org
Fixes: 7e2175eb ("KVM: x86: Fix recording of guest steal time / preempted status")
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent baea2ce5
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment