Skip to content
Commit 8a93a88c authored by Tejun Heo's avatar Tejun Heo Committed by Bruce Ashfield
Browse files

cgroup: Use open-time credentials for process migraton perm checks

commit addf0d2fbf84fa527e26af8ae670f7d85cc6c375 from
https://github.com/altera-opensource/linux-socfpga.git

[upstream commit 1756d799

]

cgroup process migration permission checks are performed at write time as
whether a given operation is allowed or not is dependent on the content of
the write - the PID. This currently uses current's credentials which is a
potential security weakness as it may allow scenarios where a less
privileged process tricks a more privileged one into writing into a fd that
it created.

This patch makes both cgroup2 and cgroup1 process migration interfaces to
use the credentials saved at the time of open (file->f_cred) instead of
current's.

Reported-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Suggested-by: default avatarLinus Torvalds <torvalds@linuxfoundation.org>
Fixes: 187fe840

 ("cgroup: require write perm on common ancestor when moving processes on the default hierarchy")
Reviewed-by: default avatarMichal Koutný <mkoutny@suse.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarWenlin Kang <wenlin.kang@windriver.com>
Signed-off-by: default avatarBruce Ashfield <bruce.ashfield@gmail.com>
parent 3b9fa41f
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment