Skip to content
Commit 7dde7a8a authored by David Sterba's avatar David Sterba
Browse files

btrfs: drop NOFAIL from set_extent_bit allocation masks



The __GFP_NOFAIL passed to set_extent_bit first appeared in 2010
(commit f0486c68 ("Btrfs: Introduce contexts for metadata
reservation")), without any explanation why it would be needed.

Meanwhile we've updated the semantics of set_extent_bit to handle failed
allocations and do unlock, sleep and retry if needed.  The use of the
NOFAIL flag is also an outlier, we never want any of the set/clear
extent bit helpers to fail, they're used for many critical changes like
extent locking, besides the extent state bit changes.

Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 0acd32c2
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment