Skip to content
Commit 584a561a authored by Doug Goldstein's avatar Doug Goldstein Committed by Konrad Rzeszutek Wilk
Browse files

xen-pciback: fix up cleanup path when alloc fails



When allocating a pciback device fails, clear the private
field. This could lead to an use-after free, however
the 'really_probe' takes care of setting
dev_set_drvdata(dev, NULL) in its failure path (which we would
exercise if the ->probe function failed), so we we
are OK. However lets be defensive as the code can change.

Going forward we should clean up the pci_set_drvdata(dev, NULL)
in the various code-base. That will be for another day.

Reviewed-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Reported-by: default avatarJonathan Creekmore <jonathan.creekmore@gmail.com>
Signed-off-by: default avatarDoug Goldstein <cardoe@cardoe.com>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent 408fb0e5
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment