Skip to content
Commit 57b0e314 authored by Eric Biggers's avatar Eric Biggers Committed by Linus Torvalds
Browse files

KEYS: fix parsing invalid pkey info string

We need to check the return value of match_token() for Opt_err before
doing anything with it.

[ Not only did the old "-1" value for Opt_err cause problems for the
  __test_and_set_bit(), as fixed in commit 94c13f66

 ("security:
  don't use a negative Opt_err token index"), but accessing
  "args[0].from" is invalid for the Opt_err case, as pointed out by Eric
  later.  - Linus ]

Reported-by: default avatar <syzbot+a22e0dc07567662c50bc@syzkaller.appspotmail.com>
Fixes: 00d60fd3

 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Cc: stable@kernel.org # 4.20
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e1ef035d
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment