Skip to content
Commit 56d977d5 authored by Jordan Crouse's avatar Jordan Crouse Committed by Rob Clark
Browse files

drm/msm/a6xx: Remove unneeded GBIF unhalt

Commit e812744c

 ("drm: msm: a6xx: Add support for A618") added a
universal GBIF un-halt into a6xx_start(). This can cause problems for
a630 targets which do not use GBIF and might have access protection
enabled on the region now occupied by the GBIF registers.

But it turns out that we didn't need to unhalt the GBIF in this path
since the stop function already takes care of that after executing a flush
but before turning off the headswitch. We should be confident that the
GBIF is open for business when we restart the hardware.

Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
Tested-by: default avatarJohn Stultz <john.stultz@linaro.org>
Reviewed-by: default avatarRob Clark <robdclark@gmail.com>
Fixes: e812744c

 ("drm: msm: a6xx: Add support for A618")
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent 7fd2dfc3
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment