Skip to content
Unverified Commit 52449c17 authored by Celeste Liu's avatar Celeste Liu Committed by Palmer Dabbelt
Browse files

riscv: entry: set a0 = -ENOSYS only when syscall != -1



When we test seccomp with 6.4 kernel, we found errno has wrong value.
If we deny NETLINK_AUDIT with EAFNOSUPPORT, after f0bddf50, we will
get ENOSYS instead. We got same result with commit 9c2598d4 ("riscv:
entry: Save a0 prior syscall_enter_from_user_mode()").

After analysing code, we think that regs->a0 = -ENOSYS should only be
executed when syscall != -1. In __seccomp_filter, when seccomp rejected
this syscall with specified errno, they will set a0 to return number as
syscall ABI, and then return -1. This return number is finally pass as
return number of syscall_enter_from_user_mode, and then is compared with
NR_syscalls after converted to ulong (so it will be ULONG_MAX). The
condition syscall < NR_syscalls will always be false, so regs->a0 = -ENOSYS
is always executed. It covered a0 set by seccomp, so we always get
ENOSYS when match seccomp RET_ERRNO rule.

Fixes: f0bddf50 ("riscv: entry: Convert to generic entry")
Reported-by: default avatarFelix Yan <felixonmars@archlinux.org>
Co-developed-by: default avatarRuizhe Pan <c141028@gmail.com>
Signed-off-by: default avatarRuizhe Pan <c141028@gmail.com>
Co-developed-by: default avatarShiqi Zhang <shiqi@isrc.iscas.ac.cn>
Signed-off-by: default avatarShiqi Zhang <shiqi@isrc.iscas.ac.cn>
Signed-off-by: default avatarCeleste Liu <CoelacanthusHex@gmail.com>
Tested-by: default avatarFelix Yan <felixonmars@archlinux.org>
Tested-by: default avatarEmil Renner Berthing <emil.renner.berthing@canonical.com>
Reviewed-by: default avatarBjörn Töpel <bjorn@rivosinc.com>
Reviewed-by: default avatarGuo Ren <guoren@kernel.org>
Link: https://lore.kernel.org/r/20230801141607.435192-1-CoelacanthusHex@gmail.com


Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent 7e381152
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment