Skip to content
Commit 50d3ea7b authored by Jeremy Kerr's avatar Jeremy Kerr Committed by Paul Gortmaker
Browse files

net: bmac: Fix read of MAC address from ROM

commit ef01cee2

 upstream.

In bmac_get_station_address, We're reading two bytes at a time from ROM,
but we do that six times, resulting in 12 bytes of read & writes. This
means we will write off the end of the six-byte destination buffer.

This change fixes the for-loop to only read/write six bytes.

Based on a proposed fix from Finn Thain <fthain@telegraphics.com.au>.

Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
Reported-by: default avatarStan Johnson <userm57@yahoo.com>
Tested-by: default avatarStan Johnson <userm57@yahoo.com>
Reported-by: default avatarFinn Thain <fthain@telegraphics.com.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 19d9160f
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment