Skip to content
Commit 4fa8fcd3 authored by Jesper Dangaard Brouer's avatar Jesper Dangaard Brouer Committed by Tony Nguyen
Browse files

igc: AF_XDP zero-copy metadata adjust breaks SKBs on XDP_PASS

Driver already implicitly supports XDP metadata access in AF_XDP
zero-copy mode, as xsk_buff_pool's xp_alloc() naturally set xdp_buff
data_meta equal data.

This works fine for XDP and AF_XDP, but if a BPF-prog adjust via
bpf_xdp_adjust_meta() and choose to call XDP_PASS, then igc function
igc_construct_skb_zc() will construct an invalid SKB packet. The
function correctly include the xdp->data_meta area in the memcpy, but
forgot to pull header to take metasize into account.

Fixes: fc9df2a0

 ("igc: Enable RX via AF_XDP zero-copy")
Signed-off-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
Tested-by: default avatarNechama Kraus <nechamax.kraus@linux.intel.com>
Acked-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 196073f9
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment