Skip to content
Commit 4e2ede7c authored by Samuel Holland's avatar Samuel Holland Committed by Greg Kroah-Hartman
Browse files

soc: sunxi: sram: Fix probe function ordering issues

[ Upstream commit 49fad91a ]

Errors from debugfs are intended to be non-fatal, and should not prevent
the driver from probing.

Since debugfs file creation is treated as infallible, move it below the
parts of the probe function that can fail. This prevents an error
elsewhere in the probe function from causing the file to leak. Do the
same for the call to of_platform_populate().

Finally, checkpatch suggests an octal literal for the file permissions.

Fixes: 4af34b57 ("drivers: soc: sunxi: Introduce SoC driver to map SRAMs")
Fixes: 5828729b

 ("soc: sunxi: export a regmap for EMAC clock reg on A64")
Reviewed-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20220815041248.53268-6-samuel@sholland.org
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 50fbc81f
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment