Skip to content
Commit 45e90b45 authored by Dan Carpenter's avatar Dan Carpenter Committed by Paul Gortmaker
Browse files

HID: hiddev: Fix race in in hiddev_disconnect()



commit 5c02c447 upstream.

Syzbot reports that "hiddev" is used after it's free in hiddev_disconnect().
The hiddev_disconnect() function sets "hiddev->exist = 0;" so
hiddev_release() can free it as soon as we drop the "existancelock"
lock.  This patch moves the mutex_unlock(&hiddev->existancelock) until
after we have finished using it.

Reported-by: default avatar <syzbot+784ccb935f9900cc7c9e@syzkaller.appspotmail.com>
Fixes: 7f77897e ("HID: hiddev: fix potential use-after-free")
Suggested-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent d82d32c4
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment