Skip to content
Commit 296abc0d authored by Andreas Gruenbacher's avatar Andreas Gruenbacher
Browse files

gfs2: No short reads or writes upon glock contention

Commit 00bfe02f ("gfs2: Fix mmap + page fault deadlocks for buffered
I/O") changed gfs2_file_read_iter() and gfs2_file_buffered_write() to
allow dropping the inode glock while faulting in user buffers.  When the
lock was dropped, a short result was returned to indicate that the
operation was interrupted.

As pointed out by Linus (see the link below), this behavior is broken
and the operations should always re-acquire the inode glock and resume
the operation instead.

Link: https://lore.kernel.org/lkml/CAHk-=whaz-g_nOOoo8RRiWNjnv2R+h6_xk2F1J4TuSRxk1MtLw@mail.gmail.com/
Fixes: 00bfe02f

 ("gfs2: Fix mmap + page fault deadlocks for buffered I/O")
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent 4fad37d5
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment