Skip to content
Commit 268e526b authored by Mikhail Kshevetskiy's avatar Mikhail Kshevetskiy Committed by Greg Kroah-Hartman
Browse files

tty/n_gsm: avoid fifo overflow in gsm_dlci_data_output



n_gsm use a simple approach: every writing to fifo correspond exactly one
reading from fifo. There are no problem in this approach until we read
less bytes then we write. As result fifo may owerflow. This leads to packet
loss and very slow responce.

For example, this happens with ping packets (about 96 byte each) and default
gsm->mtu = 64. As result we get 50 sec ping timeout and 20% packet loss.

Fix the problem by reading and sending all data from the fifo

Signed-off-by: default avatarMikhail Kshevetskiy <mikhail.kshevetskiy@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent f37ac5a1
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment