Skip to content
Commit 1fe72bcf authored by Suman Anna's avatar Suman Anna Committed by Bjorn Andersson
Browse files

remoteproc: pru: Fix wrong success return value for fw events



The irq_create_fwspec_mapping() returns a proper virq value on success
and 0 upon any failure. The pru_handle_intrmap() treats this as an error
and disposes all firmware event mappings correctly, but is returning
this incorrect value as is, letting the pru_rproc_start() interpret it
as a success and boot the PRU.

Fix this by returning an error value back upon any such failure. While
at this, revise the error trace to print some meaningful info about the
failed event.

Fixes: c75c9fda ("remoteproc: pru: Add support for PRU specific interrupt configuration")
Signed-off-by: default avatarSuman Anna <s-anna@ti.com>
Reviewed-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20210407155641.5501-3-s-anna@ti.com


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 6d1f2803
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment