Skip to content
Commit 19e5dc2e authored by Johannes Weiner's avatar Johannes Weiner Committed by Greg Kroah-Hartman
Browse files

mm: memcontrol: clarify swapaccount=0 deprecation warning

commit 118642d7 upstream.

The swapaccount deprecation warning is throwing false positives.  Since we
deprecated the knob and defaulted to enabling, the only reports we've been
getting are from folks that set swapaccount=1.  While this is a nice
affirmation that always-enabling was the right choice, we certainly don't
want to warn when users request the supported mode.

Only warn when disabling is requested, and clarify the warning.

[colin.i.king@gmail.com: spelling: "commdandline" -> "commandline"]
  Link: https://lkml.kernel.org/r/20240215090544.1649201-1-colin.i.king@gmail.com
Link: https://lkml.kernel.org/r/20240213081634.3652326-1-hannes@cmpxchg.org


Fixes: b25806dc ("mm: memcontrol: deprecate swapaccounting=0 mode")
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reported-by: default avatar"Jonas Schäfer" <jonas@wielicki.name>
Reported-by: default avatarNarcis Garcia <debianlists@actiu.net>
Suggested-by: default avatarYosry Ahmed <yosryahmed@google.com>
Signed-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Reviewed-by: default avatarYosry Ahmed <yosryahmed@google.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarShakeel Butt <shakeelb@google.com>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4c815c3a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment