Skip to content
Commit 15319a4e authored by Chengfeng Ye's avatar Chengfeng Ye Committed by David S. Miller
Browse files

atm: solos-pci: Fix potential deadlock on &tx_queue_lock

As &card->tx_queue_lock is acquired under softirq context along the
following call chain from solos_bh(), other acquisition of the same
lock inside process context should disable at least bh to avoid double
lock.

<deadlock #2>
pclose()
--> spin_lock(&card->tx_queue_lock)
<interrupt>
   --> solos_bh()
   --> fpga_tx()
   --> spin_lock(&card->tx_queue_lock)

This flaw was found by an experimental static analysis tool I am
developing for irq-related deadlock.

To prevent the potential deadlock, the patch uses spin_lock_bh()
on &card->tx_queue_lock under process context code consistently to
prevent the possible deadlock scenario.

Fixes: 213e85d3

 ("solos-pci: clean up pclose() function")
Signed-off-by: default avatarChengfeng Ye <dg573847474@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d5dba32b
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment