Skip to content
Commit 10331767 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: cfg80211: hold wiphy mutex for send_interface



Given all the locking rework in mac80211, we pretty much
need to get into the driver with the wiphy mutex held in
all callbacks. This is already mostly the case, but as
Johan reported, in the get_txpower it may not be true.

Lock the wiphy mutex around nl80211_send_iface(), then
is also around callers of nl80211_notify_iface(). This
is easy to do, fixes the problem, and aligns the locking
between various calls to it in different parts of the
code of cfg80211.

Fixes: 0e8185ce ("wifi: mac80211: check wiphy mutex in ops")
Reported-by: default avatarJohan Hovold <johan@kernel.org>
Closes: https://lore.kernel.org/r/ZVOXX6qg4vXEx8dX@hovoldconsulting.com


Tested-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 8e2f6f23
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment