Skip to content
Commit 02f1496c authored by Hangbin Liu's avatar Hangbin Liu Committed by Paul Gortmaker
Browse files

ipv6/addrconf: only check invalid header values when NETLINK_F_STRICT_CHK is set

commit 2beb6d29 upstream.

In commit 4b1373de

 ("net: ipv6: addr: perform strict checks also for
doit handlers") we add strict check for inet6_rtm_getaddr(). But we did
the invalid header values check before checking if NETLINK_F_STRICT_CHK
is set. This may break backwards compatibility if user already set the
ifm->ifa_prefixlen, ifm->ifa_flags, ifm->ifa_scope in their netlink code.

I didn't move the nlmsg_len check because I thought it's a valid check.

Reported-by: default avatarJianlin Shi <jishi@redhat.com>
Fixes: 4b1373de

 ("net: ipv6: addr: perform strict checks also for doit handlers")
Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Reviewed-by: default avatarDavid Ahern <dsahern@gmail.com>
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent d4e95ec3
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment