Skip to content
Commit a4773c55 authored by Lokesh Vutla's avatar Lokesh Vutla Committed by Tom Rini
Browse files

xyz-modem: Fix timeout loop waiting with WATCHDOG



Commit 2c77c0d6 ("xyz-modem: Change getc timeout loop waiting")
fixes the loop delay when using a hw watchdog, assuming that watchdog
kicking is taken care of by getc(). But the xyzmodem driver tries to
do a getc only after confirming that a character is available like below:
	while (!tstc()) {
		till timeout;
	}
	if (tstc())
		*c = getc();

and getc() does a watchdog reset only if it fails to see a character.
In this case, getc() always sees a character and never does a
watchdog reset. So to make sure that watchdog doesn't get reset
while loading the file, do a watchdog reset just before starting the
image loading.

Signed-off-by: default avatarLokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: default avatarVignesh R <vigneshr@ti.com>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
parent 03e6151d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment