Skip to content
  1. Oct 12, 2021
    • Randy Dunlap's avatar
      drm/connector: fix all kernel-doc warnings · f85d9e59
      Randy Dunlap authored
      Clean up all of the kernel-doc issues in drm_connector.c:
      
      drivers/gpu/drm/drm_connector.c:2611: warning: Excess function parameter 'connector' description in 'drm_connector_oob_hotplug_event'
      drivers/gpu/drm/drm_connector.c:2611: warning: Function parameter or member 'connector_fwnode' not described in 'drm_connector_oob_hotplug_event'
      
      drm_connector.c:630: warning: No description found for return value of 'drm_get_connector_status_name'
      drm_connector.c:715: warning: No description found for return value of 'drm_connector_list_iter_next'
      drm_connector.c:785: warning: No description found for return value of 'drm_get_subpixel_order_name'
      drm_connector.c:816: warning: No description found for return value of 'drm_display_info_set_bus_formats'
      drm_connector.c:1331: warning: No description found for return value of 'drm_mode_create_dvi_i_properties'
      drm_connector.c:1412: warning: No description found for return value of 'drm_connector_attach_content_type_property'
      drm_connector.c:1492: warning: No description found for return value of 'drm_mode_create_tv_margin_properties'
      drm_connector.c:1534: warning: No description found for return value of 'drm_mode_create_tv_properties'
      drm_connector.c:1627: warning: No description found for return value of 'drm_mode_create_scaling_mode_property'
      drm_connector.c:1944: warning: No description found for return value of 'drm_mode_create_suggested_offset_properties'
      
      drm_connector.c:2315: warning: missing initial short description on line:
       * drm_connector_set_panel_orientation_with_quirk -
      
      [The last warning listed is probably a quirk/bug in scripts/kernel-doc.]
      
      Fixes: 613051da ("drm: locking&new iterators for connector_list")
      Fixes: 52217195 ("drm: Extract drm_connector.[hc]")
      Fixes: b3c6c8bf ("drm: document drm_display_info")
      Fixes: 50525c33 ("drm: content-type property for HDMI connector")
      Fixes: 6c4f52dc ("drm/connector: Allow creation of margin props alone")
      Fixes: 69654c63 ("drm/connector: Split out orientation quirk detection (v2)")
      Fixes: 72ad4968
      
       ("drm/connector: Add support for out-of-band hotplug notification (v3)")
      Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: dri-devel@lists.freedesktop.org
      Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Cc: Derek Basehore <dbasehore@chromium.org>
      Cc: Hans de Goede <hdegoede@redhat.com>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Maxime Ripard <mripard@kernel.org>
      Cc: Thomas Zimmermann <tzimmermann@suse.de>
      Cc: Sam Ravnborg <sam@ravnborg.org>
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20211010224459.3603-1-rdunlap@infradead.org
      f85d9e59
    • Uwe Kleine-König's avatar
      drm/panel: s6e63m0: Make s6e63m0_remove() return void · 90c45fc1
      Uwe Kleine-König authored
      
      
      Up to now s6e63m0_remove() returns zero unconditionally. Make it return
      void instead which makes it easier to see in the callers that there is
      no error to handle.
      
      Also the return value of spi remove callbacks is ignored anyway.
      
      Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20211011132754.2479853-2-u.kleine-koenig@pengutronix.de
      90c45fc1
  2. Oct 11, 2021
  3. Oct 10, 2021
    • Zheyu Ma's avatar
      fbdev: fbmem: Fix double free of 'fb_info->pixmap.addr' · 2c0c19b6
      Zheyu Ma authored
      
      
      savagefb and some other drivers call kfree to free 'info->pixmap.addr'
      even after calling unregister_framebuffer, which may cause double free.
      
      Fix this by setting 'fb_info->pixmap.addr' to NULL after kfree in
      unregister_framebuffer.
      
      The following log reveals it:
      
      [   37.318872] BUG: KASAN: double-free or invalid-free in kfree+0x13e/0x290
      [   37.319369]
      [   37.320803] Call Trace:
      [   37.320992]  dump_stack_lvl+0xa8/0xd1
      [   37.321274]  print_address_description+0x87/0x3b0
      [   37.321632]  ? kfree+0x13e/0x290
      [   37.321879]  ? kfree+0x13e/0x290
      [   37.322126]  ? kfree+0x13e/0x290
      [   37.322374]  kasan_report_invalid_free+0x58/0x90
      [   37.322724]  ____kasan_slab_free+0x123/0x140
      [   37.323049]  __kasan_slab_free+0x11/0x20
      [   37.323347]  slab_free_freelist_hook+0x81/0x150
      [   37.323689]  ? savagefb_remove+0xa1/0xc0 [savagefb]
      [   37.324066]  kfree+0x13e/0x290
      [   37.324304]  savagefb_remove+0xa1/0xc0 [savagefb]
      [   37.324655]  pci_device_remove+0xa9/0x250
      [   37.324959]  ? pci_device_probe+0x7d0/0x7d0
      [   37.325273]  device_release_driver_internal+0x4f7/0x7a0
      [   37.325666]  driver_detach+0x1e8/0x2c0
      [   37.325952]  bus_remove_driver+0x134/0x290
      [   37.326262]  ? sysfs_remove_groups+0x97/0xb0
      [   37.326584]  driver_unregister+0x77/0xa0
      [   37.326883]  pci_unregister_driver+0x2c/0x1c0
      [   37.336124]
      [   37.336245] Allocated by task 5465:
      [   37.336507]  ____kasan_kmalloc+0xb5/0xe0
      [   37.336801]  __kasan_kmalloc+0x9/0x10
      [   37.337069]  kmem_cache_alloc_trace+0x12b/0x220
      [   37.337405]  register_framebuffer+0x3f3/0xa00
      [   37.337731]  foo_register_framebuffer+0x3b/0x50 [savagefb]
      [   37.338136]
      [   37.338255] Freed by task 5475:
      [   37.338492]  kasan_set_track+0x3d/0x70
      [   37.338774]  kasan_set_free_info+0x23/0x40
      [   37.339081]  ____kasan_slab_free+0x10b/0x140
      [   37.339399]  __kasan_slab_free+0x11/0x20
      [   37.339694]  slab_free_freelist_hook+0x81/0x150
      [   37.340034]  kfree+0x13e/0x290
      [   37.340267]  do_unregister_framebuffer+0x21c/0x3d0
      [   37.340624]  unregister_framebuffer+0x23/0x40
      [   37.340950]  savagefb_remove+0x45/0xc0 [savagefb]
      [   37.341302]  pci_device_remove+0xa9/0x250
      [   37.341603]  device_release_driver_internal+0x4f7/0x7a0
      [   37.341990]  driver_detach+0x1e8/0x2c0
      [   37.342272]  bus_remove_driver+0x134/0x290
      [   37.342577]  driver_unregister+0x77/0xa0
      [   37.342873]  pci_unregister_driver+0x2c/0x1c0
      [   37.343196]  cleanup_module+0x15/0x1c [savagefb]
      [   37.343543]  __se_sys_delete_module+0x398/0x490
      [   37.343881]  __x64_sys_delete_module+0x56/0x60
      [   37.344221]  do_syscall_64+0x4d/0xc0
      [   37.344492]  entry_SYSCALL_64_after_hwframe+0x44/0xae
      
      Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/1633848148-29747-1-git-send-email-zheyuma97@gmail.com
      2c0c19b6
    • Sam Ravnborg's avatar
      Revert "dt-bindings: add bindings for the Sharp LS060T1SX01 panel" · 2620fddc
      Sam Ravnborg authored
      This reverts commit 230a6f0e
      
      
      ("dt-bindings: add bindings for the Sharp LS060T1SX01 panel")
      
      It was pushed to drm-misc-next by accident.
      Added my own ack to expedit the revert.
      
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210926001005.3442668-2-dmitry.baryshkov@linaro.org
      2620fddc
    • Sam Ravnborg's avatar
      Revert "drm/panel: Add support for Sharp LS060T1SX01 panel" · 54d209e2
      Sam Ravnborg authored
      This reverts commit
      223cce88
      
       ("drm/panel: Add support for Sharp LS060T1SX01 panel").
      
      It was pushed to drm-misc-next by accident.
      Added my own ack to expedit the revert.
      
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210926001005.3442668-3-dmitry.baryshkov@linaro.org
      54d209e2
  4. Oct 09, 2021
  5. Oct 08, 2021
  6. Oct 07, 2021
  7. Oct 06, 2021