Skip to content
  1. Mar 19, 2014
  2. Mar 03, 2014
    • Linus Torvalds's avatar
      Linux 3.14-rc5 · 0414855f
      Linus Torvalds authored
      v3.14-rc5
      0414855f
    • Linus Torvalds's avatar
      Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux · c59224d1
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Not a huge amount happening, some MAINTAINERS updates, radeon, vmwgfx
        and tegra fixes"
      
      * 'drm-fixes' of git://people.freedesktop.org/~airlied/linux:
        drm/vmwgfx: avoid null pointer dereference at failure paths
        drm/vmwgfx: Make sure backing mobs are cleared when allocated. Update driver date.
        drm/vmwgfx: Remove some unused surface formats
        drm/radeon: enable speaker allocation setup on dce3.2
        drm/radeon: change audio enable logic
        drm/radeon: fix audio disable on dce6+
        drm/radeon: free uvd ring on unload
        drm/radeon: disable pll sharing for DP on DCE4.1
        drm/radeon: fix missing bo reservation
        drm/radeon: print the supported atpx function mask
        MAINTAINERS: update drm git tree entry
        MAINTAINERS: add entry for drm radeon driver
        drm/tegra: Add guard to avoid double disable/enable of RGB outputs
        gpu: host1x: do not check previously handled gathers
        drm/tegra: fix typo 'CONFIG_TEGRA_DRM_FBDEV'
      c59224d1
    • Linus Torvalds's avatar
      Merge tag 'usb-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb · a53c8ceb
      Linus Torvalds authored
      Pull USB fixes from Greg KH:
       "Here are 2 USB patches for 3.14-rc5, one a new device id, and the
        other fixes a reported problem with threaded irqs and the USB EHCI
        driver"
      
      * tag 'usb-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb:
        usb: ehci: fix deadlock when threadirqs option is used
        USB: ftdi_sio: add Cressi Leonardo PID
      a53c8ceb
    • Linus Torvalds's avatar
      Merge tag 'driver-core-3.14-rc5' of... · 3751c970
      Linus Torvalds authored
      Merge tag 'driver-core-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
      
      Pull sysfs fix from Greg KH:
       "Here is a single sysfs fix for 3.14-rc5.  It fixes a reported problem
        with the namespace code in sysfs"
      
      * tag 'driver-core-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core:
        sysfs: fix namespace refcnt leak
      3751c970
    • Linus Torvalds's avatar
      Merge tag 'staging-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging · 9ff7aeb6
      Linus Torvalds authored
      Pull staging tree fixes from Greg KH:
       "Here are a few IIO fixes, and a new device id for a staging driver for
        3.14-rc5.  All have been in linux-next for a while, I did a final
        merge to get the IIO fixes into this tree, they were incorrectly in
        the char-misc tree for a few weeks, and I forgot to tell you to pull
        them from there.  This makes it a single pull request for you"
      
      * tag 'staging-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging:
        staging: r8188eu: Add new device ID
        staging:iio:adc:MXS:LRADC: fix touchscreen statemachine
        iio:gyro: bug on L3GD20H gyroscope support
        iio: cm32181: Change cm32181 ambient light sensor driver
        iio: cm36651: Fix read/write integration time function.
      9ff7aeb6
    • Dave Airlie's avatar
      Merge branch 'drm-fixes-3.14' of git://people.freedesktop.org/~agd5f/linux into drm-fixes · d668ca1c
      Dave Airlie authored
      more radeon fixes
      
      * 'drm-fixes-3.14' of git://people.freedesktop.org/~agd5f/linux:
        drm/radeon: enable speaker allocation setup on dce3.2
        drm/radeon: change audio enable logic
        drm/radeon: fix audio disable on dce6+
        drm/radeon: free uvd ring on unload
        drm/radeon: disable pll sharing for DP on DCE4.1
        drm/radeon: fix missing bo reservation
        drm/radeon: print the supported atpx function mask
      d668ca1c
    • Greg Kroah-Hartman's avatar
      Merge iio fixes into staging-linus · 9f4a9b83
      Greg Kroah-Hartman authored
      
      
      These I forgot about before, but need to get into 3.14-final.
      
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      9f4a9b83
    • Linus Torvalds's avatar
      Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 3154da34
      Linus Torvalds authored
      Pull perf fixes from Ingo Molnar:
       "Misc fixes, most of them on the tooling side"
      
      * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        perf tools: Fix strict alias issue for find_first_bit
        perf tools: fix BFD detection on opensuse
        perf: Fix hotplug splat
        perf/x86: Fix event scheduling
        perf symbols: Destroy unused symsrcs
        perf annotate: Check availability of annotate when processing samples
      3154da34
  3. Mar 02, 2014
    • Dave Airlie's avatar
      Merge tag 'vmwgfx-fixes-3.14-2014-03-02' of... · 49e893b5
      Dave Airlie authored
      Merge tag 'vmwgfx-fixes-3.14-2014-03-02' of git://people.freedesktop.org/~thomash/linux into drm-fixes
      
      A couple of minor fixes.
      
      Pull request of 2014-03-02
      
      * tag 'vmwgfx-fixes-3.14-2014-03-02' of git://people.freedesktop.org/~thomash/linux:
        drm/vmwgfx: avoid null pointer dereference at failure paths
        drm/vmwgfx: Make sure backing mobs are cleared when allocated. Update driver date.
        drm/vmwgfx: Remove some unused surface formats
      49e893b5
    • Alexey Khoroshilov's avatar
      drm/vmwgfx: avoid null pointer dereference at failure paths · 6950e23e
      Alexey Khoroshilov authored
      
      
      vmw_takedown_otable_base() and vmw_mob_unbind() check for
      potential vmw_fifo_reserve() failure and print error message,
      but then immediately dereference NULL pointer.
      
      Found by Linux Driver Verification project (linuxtesting.org).
      
      Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
      Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
      6950e23e
    • Thomas Hellstrom's avatar
      drm/vmwgfx: Make sure backing mobs are cleared when allocated. Update driver date. · a34417f6
      Thomas Hellstrom authored
      
      
      Backing mob contents is propagated to user-space, so make sure backing
      mobs are cleared when allocated. This also accidently fix rendering errors
      with celestia when emulating legacy mode.
      
      Also update driver date.
      
      Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
      Reviewed-by: default avatarBrian Paul <brianp@vmware.com>
      a34417f6
    • Thomas Hellstrom's avatar
      drm/vmwgfx: Remove some unused surface formats · ae204569
      Thomas Hellstrom authored
      
      
      These formats are deprecated.
      
      Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
      Reviewed-by: default avatarBrian Paul <brianp@vmware.com>
      ae204569
    • Linus Torvalds's avatar
      Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 55de1ed2
      Linus Torvalds authored
      Pull x86 fixes from Peter Anvin:
       "The VMCOREINFO patch I'll pushing for this release to avoid having a
        release with kASLR and but without that information.
      
        I was hoping to include the FPU patches from Suresh, but ran into a
        problem (see other thread); will try to make them happen next week"
      
      * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86, kaslr: add missed "static" declarations
        x86, kaslr: export offset in VMCOREINFO ELF notes
      55de1ed2
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending · 702256e6
      Linus Torvalds authored
      Pull SCSI target fixes from Nicholas Bellinger:
       "The bulk of the series are bugfixes for qla2xxx target NPIV support
        that went in for v3.14-rc1.  Also included are a few DIF related
        fixes, a qla2xxx fix (Cc'ed to stable) from Greg W., and vhost/scsi
        protocol version related fix from Venkatesh.
      
        Also just a heads up that a series to address a number of issues with
        iser-target active I/O reset/shutdown is still being tested, and will
        be included in a separate -rc6 PULL request"
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending:
        vhost/scsi: Check LUN structure byte 0 is set to 1, per spec
        qla2xxx: Fix kernel panic on selective retransmission request
        Target/sbc: Don't use sg as iterator in sbc_verify_read
        target: Add DIF sense codes in transport_generic_request_failure
        target/sbc: Fix sbc_dif_copy_prot addr offset bug
        tcm_qla2xxx: Fix NAA formatted name for NPIV WWPNs
        tcm_qla2xxx: Perform configfs depend/undepend for base_tpg
        tcm_qla2xxx: Add NPIV specific enable/disable attribute logic
        qla2xxx: Check + fail when npiv_vports_inuse exists in shutdown
        qla2xxx: Fix qlt_lport_register base_vha callback race
      702256e6
    • Linus Torvalds's avatar
      Merge branch 'fixes' of git://git.infradead.org/users/vkoul/slave-dma · 3750c140
      Linus Torvalds authored
      Pull slave-dma fixes from Vinod Koul:
       "This request brings you two small fixes.  First one for fixing
        dereference of freed descriptor and second for fixing sdma bindings
        for it to work for imx25.
      
        I was planning to send this about 10days ago but then I had to proceed
        on my paternity leave and didnt get chance to send this.  Now got a
        bit of time from dady duties :)"
      
      * 'fixes' of git://git.infradead.org/users/vkoul/slave-dma:
        dma: sdma: Add imx25 compatible
        dma: ste_dma40: don't dereference free:d descriptor
      3750c140
    • Linus Torvalds's avatar
      Merge tag 'pm+acpi-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 751a03c3
      Linus Torvalds authored
      Pull ACPI and power management fixes from Rafael Wysocki:
       "These three commits fix a recent intel_pstate regression and two old
        bugs that should be fixed in -stable too, one in the ACPI processor
        driver and one in the firmare loader.
      
        Specifics:
      
         - One of the recent intel_pstate driver fixes introduced a rounding
           error that on some systems causes the frequency to be stuck at the
           lowest level forever.  Fix from Dirk Brandewie.
      
         - The firmware_class driver's PM notifier doesn't handle the
           PM_RESTORE_PREPARE event during hibernation image restore and that
           leads to a deadlock on umhelper_sem in __usermodehelper_disable().
           Fix from Sebastian Capella.
      
         - acpi_processor_set_throttling() abuses set_cpus_allowed_ptr() in a
           nasty way which triggers the WARN_ON_ONCE() in wq_worker_waking_up()
           among other things.  Fix from Lan Tianyu"
      
      * tag 'pm+acpi-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        ACPI / processor: Rework processor throttling with work_on_cpu()
        PM / hibernate: Fix restore hang in freeze_processes()
        intel_pstate: Change busy calculation to use fixed point math.
      751a03c3
  4. Mar 01, 2014
    • Ingo Molnar's avatar
      Merge tag 'perf-urgent-for-mingo' of... · af76815a
      Ingo Molnar authored
      
      Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
      
      Pull perf/urgent build fixes for certain distro environments, from Arnaldo Carvalho de Melo:
      
        * Problem on recent gcc on x86-32 related to strict alias issue for
          find_first_bit (Jiri Olsa).
      
        * OpenSuSE: BFD detection problems related to not explicitely listing all
          required libraries (Andi Kleen)
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      af76815a
    • Greg Kroah-Hartman's avatar
      Merge tag 'fixes-for-3.14d' of... · d3dae4ad
      Greg Kroah-Hartman authored
      Merge tag 'fixes-for-3.14d' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus
      
      Jonathan writes:
      
      Fourth set of IIO fixes for the 3.14 kernel.
      
      A single line patch fixing a regression that was introduced in 3.13 in the
      reworking of the mxs touch screen and ADC drivers to be interrupt rather
      than polling driven.  It resulted in a stray double reporting of the release
      coordinate in the touch screen driver.  The bug lay in the adc side
      of the driver which left the statemachine in the wrong state.
      d3dae4ad
    • Russell King's avatar
      MAINTAINERS: add maintainer entry for Armada DRM driver · 8427defd
      Russell King authored
      
      
      Add a maintainers entry for the Armada DRM driver.
      
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      8427defd
    • Linus Torvalds's avatar
      Merge tag 'dm-3.14-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm · ebb7c197
      Linus Torvalds authored
      Pull device mapper fixes from Mike Snitzer:
       "A few dm-cache fixes, an invalid ioctl handling fix for dm multipath,
        a couple immutable biovec fixups for dm mirror, and a few dm-thin
        fixes.
      
        There will likely be additional dm-thin metadata and data resize fixes
        to include in 3.14-rc6 next week.
      
        Note to stable-minded folks: Immutable biovecs were introduced in
        3.14, so the related fixups for dm mirror are not needed in stable@
        kernels"
      
      * tag 'dm-3.14-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm:
        dm cache: fix truncation bug when mapping I/O to >2TB fast device
        dm thin: allow metadata space larger than supported to go unused
        dm mpath: fix stalls when handling invalid ioctls
        dm thin: fix the error path for the thin device constructor
        dm raid1: fix immutable biovec related BUG when retrying read bio
        dm io: fix I/O to multiple destinations
        dm thin: avoid metadata commit if a pool's thin devices haven't changed
        dm cache: do not add migration to completed list before unhooking bio
        dm cache: move hook_info into common portion of per_bio_data structure
      ebb7c197
    • Linus Torvalds's avatar
      Merge tag 'sound-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · 7aa48355
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "It's a bad habit to get a higher volume of fixes often lately, but
        things happen again.
      
        All commits found here are real bug fixes, and are mostly trivial.
        Most of changes in ASoC are the fixes for enum items due to the wrong
        API usages, in addition to a few DAPM mutex deadlock and other fixes.
        In HD-audio, only fixups for HP laptops.  Although diffstat shows
        much, the changes are simple: there are just so many different device
        entries there"
      
      * tag 'sound-3.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound:
        ASoC: sta32x: Fix wrong enum for limiter2 release rate
        ASoC: da732x: Mark DC offset control registers volatile
        ALSA: hda/realtek - Add more entry for enable HP mute led
        ALSA: hda - Add a fixup for HP Folio 13 mute LED
        ASoC: wm8958-dsp: Fix firmware block loading
        ASoC: sta32x: Fix cache sync
        ALSA: hda/realtek - Add more entry for enable HP mute led
        ASoC: dapm: Add locking to snd_soc_dapm_xxxx_pin functions
        Input - arizona-haptics: Fix double lock of dapm_mutex
        ASoC: wm8400: Fix the wrong number of enum items
        ASoC: isabelle: Fix the wrong number of items in enum ctls
        ASoC: ad1980: Fix wrong number of items for capture source
        ASoC: wm8994: Fix the wrong number of enum items
        ASoC: wm8900: Fix the wrong number of enum items
        ASoC: wm8770: Fix wrong number of enum items
        ASoC: sta32x: Fix array access overflow
        ASoC: dapm: Correct regulator bypass error messages
      7aa48355
    • Linus Torvalds's avatar
      Merge tag 'edac_fixes_for_3.14' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp · 04b52252
      Linus Torvalds authored
      Pull EDAC fixes from Borislav Petkov:
       "Two fixes below for PCI devices disappearing when a reference count
        underflow happens after a couple of insmod/rmmod cycles in succession"
      
      * tag 'edac_fixes_for_3.14' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp:
        i7300_edac: Fix device reference count
        i7core_edac: Fix PCI device reference count
      04b52252
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · d8efcf38
      Linus Torvalds authored
      Pull KVM fixes from Paolo Bonzini:
       "Three x86 fixes and one for ARM/ARM64.
      
        In particular, nested virtualization on Intel is broken in 3.13 and
        fixed by this pull request"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        kvm, vmx: Really fix lazy FPU on nested guest
        kvm: x86: fix emulator buffer overflow (CVE-2014-0049)
        arm/arm64: KVM: detect CPU reset on CPU_PM_EXIT
        KVM: MMU: drop read-only large sptes when creating lower level sptes
      d8efcf38
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 78d9e934
      Linus Torvalds authored
      Pull ARM64 fixes from Catalin Marinas:
       - !CONFIG_SMP build fix
       - pte bit testing macros conversion fix (int truncates top bits of
         long)
       - stack unwinding PC calculation fix
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: Fix !CONFIG_SMP kernel build
        arm64: mm: Add double logical invert to pte accessors
        ARM64: unwind: Fix PC calculation
      78d9e934
    • Linus Torvalds's avatar
      Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc · f94def76
      Linus Torvalds authored
      Pull powerpc fixes from Ben Herrenschmidt:
       "Here are a few more powerpc fixes for 3.14.
      
        Most of these are also CC'ed to stable and fix bugs in new
        functionality introduced in the last 2 or 3 versions"
      
      * 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc:
        powerpc/powernv: Fix indirect XSCOM unmangling
        powerpc/powernv: Fix opal_xscom_{read,write} prototype
        powerpc/powernv: Refactor PHB diag-data dump
        powerpc/powernv: Dump PHB diag-data immediately
        powerpc: Increase stack redzone for 64-bit userspace to 512 bytes
        powerpc/ftrace: bugfix for test_24bit_addr
        powerpc/crashdump : Fix page frame number check in copy_oldmem_page
        powerpc/le: Ensure that the 'stop-self' RTAS token is handled correctly
      f94def76
    • Catalin Marinas's avatar
      arm64: Fix !CONFIG_SMP kernel build · b57fc9e8
      Catalin Marinas authored
      Commit fb4a9602
      
       (arm64: kernel: fix per-cpu offset restore on
      resume) uses per_cpu_offset() unconditionally during CPU wakeup,
      however, this is only defined for the SMP case.
      
      Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
      Reported-by: default avatarDave P Martin <Dave.Martin@arm.com>
      b57fc9e8
  5. Feb 28, 2014
    • Steve Capper's avatar
      arm64: mm: Add double logical invert to pte accessors · 84fe6826
      Steve Capper authored
      
      
      Page table entries on ARM64 are 64 bits, and some pte functions such as
      pte_dirty return a bitwise-and of a flag with the pte value. If the
      flag to be tested resides in the upper 32 bits of the pte, then we run
      into the danger of the result being dropped if downcast.
      
      For example:
      	gather_stats(page, md, pte_dirty(*pte), 1);
      where pte_dirty(*pte) is downcast to an int.
      
      This patch adds a double logical invert to all the pte_ accessors to
      ensure predictable downcasting.
      
      Signed-off-by: default avatarSteve Capper <steve.capper@linaro.org>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
      84fe6826
    • Heinz Mauelshagen's avatar
      dm cache: fix truncation bug when mapping I/O to >2TB fast device · e0d849fa
      Heinz Mauelshagen authored
      
      
      When remapping a block to the cache's fast device that is larger than
      2TB we must not truncate the destination sector to 32bits.  The 32bit
      temporary result of from_cblock() was being overflowed in
      remap_to_cache() due to the logical left shift.
      
      Use an intermediate 64bit type to store the 32bit from_cblock() result
      to fix the overflow.
      
      Signed-off-by: default avatarHeinz Mauelshagen <heinzm@redhat.com>
      Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
      Cc: stable@vger.kernel.org
      e0d849fa
    • Jiri Olsa's avatar
      perf tools: Fix strict alias issue for find_first_bit · b39c2a57
      Jiri Olsa authored
      
      
      When compiling perf tool code with gcc 4.4.7 I'm getting
      following error:
      
          CC       util/session.o
        cc1: warnings being treated as errors
        util/session.c: In function ‘perf_session_deliver_event’:
        tools/perf/util/include/linux/bitops.h:109: error: dereferencing pointer ‘p’ does break strict-aliasing rules
        tools/perf/util/include/linux/bitops.h:101: error: dereferencing pointer ‘p’ does break strict-aliasing rules
        util/session.c:697: note: initialized from here
        tools/perf/util/include/linux/bitops.h:101: note: initialized from here
        make[1]: *** [util/session.o] Error 1
        make: *** [util/session.o] Error 2
      
      The aliased types here are u64 and unsigned long pointers, which is safe
      for the find_first_bit processing.
      
      This error shows up for me only for gcc 4.4 on 32bit x86, even for
      -Wstrict-aliasing=3, while newer gcc are quiet and scream here for
      -Wstrict-aliasing={2,1}. Looks like newer gcc changed the rules for
      strict alias warnings.
      
      The gcc documentation offers workaround for valid aliasing by using
      __may_alias__ attribute:
      
        http://gcc.gnu.org/onlinedocs/gcc-4.4.0/gcc/Type-Attributes.html
      
      Using this workaround for the find_first_bit function.
      
      Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Ingo Molnar <mingo@elte.hu>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/1393434867-20271-1-git-send-email-jolsa@redhat.com
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      b39c2a57