Skip to content
  1. Jun 26, 2020
    • Stafford Horne's avatar
      openrisc: fix boot oops when DEBUG_VM is enabled · 313a5257
      Stafford Horne authored
      Since v5.8-rc1 OpenRISC Linux fails to boot when DEBUG_VM is enabled.
      This has been bisected to commit 42fc5414 ("mmap locking API: add
      mmap_assert_locked() and mmap_assert_write_locked()").
      
      The added locking checks exposed the issue that OpenRISC was not taking
      this mmap lock when during page walks for DMA operations.  This patch
      locks and unlocks the mmap lock for page walking.
      
      Link: http://lkml.kernel.org/r/20200617090247.1680188-1-shorne@gmail.com
      Fixes: 42fc5414
      
       ("mmap locking API: add mmap_assert_locked() and mmap_assert_write_locked()"
      Signed-off-by: default avatarStafford Horne <shorne@gmail.com>
      Reviewed-by: default avatarMichel Lespinasse <walken@google.com>
      Cc: Jonas Bonn <jonas@southpole.se>
      Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
      Cc: Jason Gunthorpe <jgg@ziepe.ca>
      Cc: Steven Price <steven.price@arm.com>
      Cc: Thomas Hellstrom <thellstrom@vmware.com>
      Cc: Robin Murphy <robin.murphy@arm.com>
      Cc: Vlastimil Babka <vbabka@suse.cz>
      Cc: Daniel Jordan <...
      313a5257
    • Linus Torvalds's avatar
      Merge tag 's390-5.8-3' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux · 908f7d12
      Linus Torvalds authored
      Pull s390 fixes from Heiko Carstens:
      
       - Fix kernel crash on system call single stepping.
      
       - Make sure early program check handler is executed with DAT on to
         avoid an endless program check loop.
      
       - Add __GFP_NOWARN flag to debug feature to avoid user triggerable
         allocation failure messages.
      
      * tag 's390-5.8-3' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux:
        s390/debug: avoid kernel warning on too large number of pages
        s390/kasan: fix early pgm check handler execution
        s390: fix system call single stepping
      908f7d12
    • Linus Torvalds's avatar
      Merge tag 'sound-5.8-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · a4d3712b
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "A collection of small fixes gathered in the last two weeks.
      
        The major changes here are fixes for the recent DPCM regressions found
        on i.MX and Qualcomm platforms and fixes for resource leaks in ASoC
        DAI registrations.
      
        Other than those are mostly device-specific fixes including the usual
        USB- and HD-audio quirks, and a fix for syzkaller case and ID updates
        for new Intel platforms"
      
      * tag 'sound-5.8-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (32 commits)
        ALSA: usb-audio: Fix OOB access of mixer element list
        ALSA: usb-audio: add quirk for Samsung USBC Headset (AKG)
        ALSA: usb-audio: Add registration quirk for Kingston HyperX Cloud Flight S
        ASoC: rockchip: Fix a reference count leak.
        ASoC: amd: closing specific instance.
        ALSA: hda: Intel: add missing PCI IDs for ICL-H, TGL-H and EKL
        ASoC: hdac_hda: fix memleak with regmap not freed on r...
      a4d3712b
  2. Jun 25, 2020
    • Linus Torvalds's avatar
      Merge tag 'erofs-for-5.8-rc3-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs · 8be3a53e
      Linus Torvalds authored
      Pull erofs fix from Gao Xiang:
       "Fix a regression which uses potential uninitialized high 32-bit value
        unexpectedly recently observed with specific compiler options"
      
      * tag 'erofs-for-5.8-rc3-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs:
        erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup
      8be3a53e
    • Linus Torvalds's avatar
      Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost · fc10807d
      Linus Torvalds authored
      Pull virtio fixes from Michael Tsirkin:
       "Fixes all over the place.
      
        This includes a couple of tests that I would normally defer, but since
        they have already been helpful in catching some bugs, don't build for
        any users at all, and having them upstream makes life easier for
        everyone, I think it's ok even at this late stage"
      
      * tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost:
        tools/virtio: Use tools/include/list.h instead of stubs
        tools/virtio: Reset index in virtio_test --reset.
        tools/virtio: Extract virtqueue initialization in vq_reset
        tools/virtio: Use __vring_new_virtqueue in virtio_test.c
        tools/virtio: Add --reset
        tools/virtio: Add --batch=random option
        tools/virtio: Add --batch option
        virtio-mem: add memory via add_memory_driver_managed()
        virtio-mem: silence a static checker warning
        vhost_vdpa: Fix potential underflow in vhost_vdpa_mmap()
        vdpa: fix typos in the comments for __vdpa_alloc_device()
      fc10807d
    • Linus Torvalds's avatar
      Merge tag 'for-linus-2020-06-24' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux · fbb58011
      Linus Torvalds authored
      Pull thread fix from Christian Brauner:
       "This fixes a regression introduced with 303cc571 ("nsproxy: attach
        to namespaces via pidfds").
      
        The LTP testsuite reported a regression where users would now see
        EBADF returned instead of EINVAL when an fd was passed that referred
        to an open file but the file was not a namespace file.
      
        Fix this by continuing to report EINVAL and add a regression test"
      
      * tag 'for-linus-2020-06-24' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux:
        tests: test for setns() EINVAL regression
        nsproxy: restore EINVAL for non-namespace file descriptor
      fbb58011
  3. Jun 24, 2020
    • Takashi Iwai's avatar
      ALSA: usb-audio: Fix OOB access of mixer element list · 220345e9
      Takashi Iwai authored
      
      
      The USB-audio mixer code holds a linked list of usb_mixer_elem_list,
      and several operations are performed for each mixer element.  A few of
      them (snd_usb_mixer_notify_id() and snd_usb_mixer_interrupt_v2())
      assume each mixer element being a usb_mixer_elem_info object that is a
      subclass of usb_mixer_elem_list, cast via container_of() and access it
      members.  This may result in an out-of-bound access when a
      non-standard list element has been added, as spotted by syzkaller
      recently.
      
      This patch adds a new field, is_std_info, in usb_mixer_elem_list to
      indicate that the element is the usb_mixer_elem_info type or not, and
      skip the access to such an element if needed.
      
      Reported-by: default avatar <syzbot+fb14314433463ad51625@syzkaller.appspotmail.com>
      Reported-by: default avatar <syzbot+2405ca3401e943c538b5@syzkaller.appspotmail.com>
      Cc: <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/20200624122340.9615-1-tiwai@suse.de
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      220345e9
    • Gao Xiang's avatar
      erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup · 3c597282
      Gao Xiang authored
      
      
      Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with
      specific aarch64 environment easily, which wasn't shown before.
      
      After digging into that, I found that high 32 bits of page->private
      was set to 0xaaaaaaaa rather than 0 (due to z_erofs_onlinepage_init
      behavior with specific compiler options). Actually we only use low
      32 bits to keep the page information since page->private is only 4
      bytes on most 32-bit platforms. However z_erofs_onlinepage_fixup()
      uses the upper 32 bits by mistake.
      
      Let's fix it now.
      
      Reported-and-tested-by: default avatarHongyu Jin <hongyu.jin@unisoc.com>
      Fixes: 3883a79a
      
       ("staging: erofs: introduce VLE decompression support")
      Cc: <stable@vger.kernel.org> # 4.19+
      Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
      Link: https://lore.kernel.org/r/20200618234349.22553-1-hsiangkao@aol.com
      Signed-off-by: default avatarGao Xiang <hsiangkao@redhat.com>
      3c597282
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · 26e122e9
      Linus Torvalds authored
      Pull kvm fixes from Paolo Bonzini:
       "All bugfixes except for a couple cleanup patches"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        KVM: VMX: Remove vcpu_vmx's defunct copy of host_pkru
        KVM: x86: allow TSC to differ by NTP correction bounds without TSC scaling
        KVM: X86: Fix MSR range of APIC registers in X2APIC mode
        KVM: VMX: Stop context switching MSR_IA32_UMWAIT_CONTROL
        KVM: nVMX: Plumb L2 GPA through to PML emulation
        KVM: x86/mmu: Avoid mixing gpa_t with gfn_t in walk_addr_generic()
        KVM: LAPIC: ensure APIC map is up to date on concurrent update requests
        kvm: lapic: fix broken vcpu hotplug
        Revert "KVM: VMX: Micro-optimize vmexit time when not exposing PMU"
        KVM: VMX: Add helpers to identify interrupt type from intr_info
        kvm/svm: disable KCSAN for svm_vcpu_run()
        KVM: MIPS: Fix a build error for !CPU_LOONGSON64
      26e122e9
    • Linus Torvalds's avatar
      Merge tag 'for-5.8-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux · 3e08a952
      Linus Torvalds authored
      Pull btrfs fixes from David Sterba:
       "A number of fixes, located in two areas, one performance fix and one
        fixup for better integration with another patchset.
      
         - bug fixes in nowait aio:
             - fix snapshot creation hang after nowait-aio was used
             - fix failure to write to prealloc extent past EOF
             - don't block when extent range is locked
      
         - block group fixes:
             - relocation failure when scrub runs in parallel
             - refcount fix when removing fails
             - fix race between removal and creation
             - space accounting fixes
      
         - reinstante fast path check for log tree at unlink time, fixes
           performance drop up to 30% in REAIM
      
         - kzfree/kfree fixup to ease treewide patchset renaming kzfree"
      
      * tag 'for-5.8-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux:
        btrfs: use kfree() in btrfs_ioctl_get_subvol_info()
        btrfs: fix RWF_NOWAIT writes blocking on extent locks and waiting for IO
        btrfs: fix RWF_NOWAIT write not failling when we need to cow
        btrfs: fix failure of RWF_NOWAIT write into prealloc extent beyond eof
        btrfs: fix hang on snapshot creation after RWF_NOWAIT write
        btrfs: check if a log root exists before locking the log_mutex on unlink
        btrfs: fix bytes_may_use underflow when running balance and scrub in parallel
        btrfs: fix data block group relocation failure due to concurrent scrub
        btrfs: fix race between block group removal and block group creation
        btrfs: fix a block group ref counter leak after failure to remove block group
      3e08a952
  4. Jun 23, 2020
    • Macpaul Lin's avatar
      ALSA: usb-audio: add quirk for Samsung USBC Headset (AKG) · a32a1fc9
      Macpaul Lin authored
      
      
      We've found Samsung USBC Headset (AKG) (VID: 0x04e8, PID: 0xa051)
      need a tiny delay after each class compliant request.
      Otherwise the device might not be able to be recognized each times.
      
      Signed-off-by: default avatarChihhao Chen <chihhao.chen@mediatek.com>
      Signed-off-by: default avatarMacpaul Lin <macpaul.lin@mediatek.com>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/1592910203-24035-1-git-send-email-macpaul.lin@mediatek.com
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      a32a1fc9
    • Christian Borntraeger's avatar
      s390/debug: avoid kernel warning on too large number of pages · 827c4913
      Christian Borntraeger authored
      
      
      When specifying insanely large debug buffers a kernel warning is
      printed. The debug code does handle the error gracefully, though.
      Instead of duplicating the check let us silence the warning to
      avoid crashes when panic_on_warn is used.
      
      Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
      Reviewed-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      827c4913
    • Vasily Gorbik's avatar
      s390/kasan: fix early pgm check handler execution · 998f5bbe
      Vasily Gorbik authored
      
      
      Currently if early_pgm_check_handler is called it ends up in pgm check
      loop. The problem is that early_pgm_check_handler is instrumented by
      KASAN but executed without DAT flag enabled which leads to addressing
      exception when KASAN checks try to access shadow memory.
      
      Fix that by executing early handlers with DAT flag on under KASAN as
      expected.
      
      Reported-and-tested-by: default avatarAlexander Egorenkov <egorenar@linux.ibm.com>
      Reviewed-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
      Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      998f5bbe
    • Sven Schnelle's avatar
      s390: fix system call single stepping · e64a1618
      Sven Schnelle authored
      When single stepping an svc instruction on s390, the kernel is entered
      with a PER program check interruption. The program check handler than
      jumps to the system call handler by reloading the PSW. The code didn't
      set GPR13 to the thread pointer in struct task_struct. This made the
      kernel access invalid memory while trying to fetch the syscall function
      address. Fix this by always assigned GPR13 after .Lsysc_per.
      
      Fixes: 0b0ed657
      
       ("s390: remove critical section cleanup from entry.S")
      Reported-and-tested-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
      Signed-off-by: default avatarSven Schnelle <svens@linux.ibm.com>
      Reviewed-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
      e64a1618
    • Christoffer Nielsen's avatar
      ALSA: usb-audio: Add registration quirk for Kingston HyperX Cloud Flight S · 73094608
      Christoffer Nielsen authored
      
      
      Similar to the Kingston HyperX AMP, the Kingston HyperX Cloud
      Alpha S (0951:0x16ea) uses two interfaces, but only the second
      interface contains the capture stream. This patch delays the
      registration until the second interface appears.
      
      Signed-off-by: default avatarChristoffer Nielsen <cn@obviux.dk>
      Cc: <stable@vger.kernel.org>
      Link: https://lore.kernel.org/r/CAOtG2YHOM3zy+ed9KS-J4HkZo_QGzcUG9MigSp4e4_-13r6B=Q@mail.gmail.com
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      73094608
    • Sean Christopherson's avatar
      KVM: VMX: Remove vcpu_vmx's defunct copy of host_pkru · e4553b49
      Sean Christopherson authored
      Remove vcpu_vmx.host_pkru, which got left behind when PKRU support was
      moved to common x86 code.
      
      No functional change intended.
      
      Fixes: 37486135
      
       ("KVM: x86: Fix pkru save/restore when guest CR4.PKE=0, move it to x86.c")
      Signed-off-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
      Message-Id: <20200617034123.25647-1-sean.j.christopherson@intel.com>
      Reviewed-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
      Reviewed-by: default avatarJim Mattson <jmattson@google.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      e4553b49
    • Marcelo Tosatti's avatar
      KVM: x86: allow TSC to differ by NTP correction bounds without TSC scaling · 26769f96
      Marcelo Tosatti authored
      
      
      The Linux TSC calibration procedure is subject to small variations
      (its common to see +-1 kHz difference between reboots on a given CPU, for example).
      
      So migrating a guest between two hosts with identical processor can fail, in case
      of a small variation in calibrated TSC between them.
      
      Without TSC scaling, the current kernel interface will either return an error
      (if user_tsc_khz <= tsc_khz) or enable TSC catchup mode.
      
      This change enables the following TSC tolerance check to
      accept KVM_SET_TSC_KHZ within tsc_tolerance_ppm (which is 250ppm by default).
      
              /*
               * Compute the variation in TSC rate which is acceptable
               * within the range of tolerance and decide if the
               * rate being applied is within that bounds of the hardware
               * rate.  If so, no scaling or compensation need be done.
               */
              thresh_lo = adjust_tsc_khz(tsc_khz, -tsc_tolerance_ppm);
              thresh_hi = adjust_tsc_khz(tsc_khz, tsc_tolerance_ppm);
              if (user_tsc_khz < thresh_lo || user_tsc_khz > thresh_hi) {
                      pr_debug("kvm: requested TSC rate %u falls outside tolerance [%u,%u]\n", user_tsc_khz, thresh_lo, thresh_hi);
                      use_scaling = 1;
              }
      
      NTP daemon in the guest can correct this difference (NTP can correct upto 500ppm).
      
      Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
      
      Message-Id: <20200616114741.GA298183@fuller.cnet>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      26769f96
    • Xiaoyao Li's avatar
      KVM: X86: Fix MSR range of APIC registers in X2APIC mode · bf10bd0b
      Xiaoyao Li authored
      Only MSR address range 0x800 through 0x8ff is architecturally reserved
      and dedicated for accessing APIC registers in x2APIC mode.
      
      Fixes: 0105d1a5
      
       ("KVM: x2apic interface to lapic")
      Signed-off-by: default avatarXiaoyao Li <xiaoyao.li@intel.com>
      Message-Id: <20200616073307.16440-1-xiaoyao.li@intel.com>
      Cc: stable@vger.kernel.org
      Reviewed-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
      Reviewed-by: default avatarJim Mattson <jmattson@google.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      bf10bd0b
    • Sean Christopherson's avatar
      KVM: VMX: Stop context switching MSR_IA32_UMWAIT_CONTROL · bf09fb6c
      Sean Christopherson authored
      Remove support for context switching between the guest's and host's
      desired UMWAIT_CONTROL.  Propagating the guest's value to hardware isn't
      required for correct functionality, e.g. KVM intercepts reads and writes
      to the MSR, and the latency effects of the settings controlled by the
      MSR are not architecturally visible.
      
      As a general rule, KVM should not allow the guest to control power
      management settings unless explicitly enabled by userspace, e.g. see
      KVM_CAP_X86_DISABLE_EXITS.  E.g. Intel's SDM explicitly states that C0.2
      can improve the performance of SMT siblings.  A devious guest could
      disable C0.2 so as to improve the performance of their workloads at the
      detriment to workloads running in the host or on other VMs.
      
      Wholesale removal of UMWAIT_CONTROL context switching also fixes a race
      condition where updates from the host may cause KVM to enter the guest
      with the incorrect value.  Because updates are are propagated to all
      CPUs via IPI (SMP function callback), the value in hardware may be
      stale with respect to the cached value and KVM could enter the guest
      with the wrong value in hardware.  As above, the guest can't observe the
      bad value, but it's a weird and confusing wart in the implementation.
      
      Removal also fixes the unnecessary usage of VMX's atomic load/store MSR
      lists.  Using the lists is only necessary for MSRs that are required for
      correct functionality immediately upon VM-Enter/VM-Exit, e.g. EFER on
      old hardware, or for MSRs that need to-the-uop precision, e.g. perf
      related MSRs.  For UMWAIT_CONTROL, the effects are only visible in the
      kernel via TPAUSE/delay(), and KVM doesn't do any form of delay in
      vcpu_vmx_run().  Using the atomic lists is undesirable as they are more
      expensive than direct RDMSR/WRMSR.
      
      Furthermore, even if giving the guest control of the MSR is legitimate,
      e.g. in pass-through scenarios, it's not clear that the benefits would
      outweigh the overhead.  E.g. saving and restoring an MSR across a VMX
      roundtrip costs ~250 cycles, and if the guest diverged from the host
      that cost would be paid on every run of the guest.  In other words, if
      there is a legitimate use case then it should be enabled by a new
      per-VM capability.
      
      Note, KVM still needs to emulate MSR_IA32_UMWAIT_CONTROL so that it can
      correctly expose other WAITPKG features to the guest, e.g. TPAUSE,
      UMWAIT and UMONITOR.
      
      Fixes: 6e3ba4ab
      
       ("KVM: vmx: Emulate MSR IA32_UMWAIT_CONTROL")
      Cc: stable@vger.kernel.org
      Cc: Jingqi Liu <jingqi.liu@intel.com>
      Cc: Tao Xu <tao3.xu@intel.com>
      Signed-off-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
      Message-Id: <20200623005135.10414-1-sean.j.christopherson@intel.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      bf09fb6c
    • Sean Christopherson's avatar
      KVM: nVMX: Plumb L2 GPA through to PML emulation · 2dbebf7a
      Sean Christopherson authored
      Explicitly pass the L2 GPA to kvm_arch_write_log_dirty(), which for all
      intents and purposes is vmx_write_pml_buffer(), instead of having the
      latter pull the GPA from vmcs.GUEST_PHYSICAL_ADDRESS.  If the dirty bit
      update is the result of KVM emulation (rare for L2), then the GPA in the
      VMCS may be stale and/or hold a completely unrelated GPA.
      
      Fixes: c5f983f6
      
       ("nVMX: Implement emulated Page Modification Logging")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
      Message-Id: <20200622215832.22090-2-sean.j.christopherson@intel.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      2dbebf7a
    • Vitaly Kuznetsov's avatar
      KVM: x86/mmu: Avoid mixing gpa_t with gfn_t in walk_addr_generic() · 312d16c7
      Vitaly Kuznetsov authored
      
      
      translate_gpa() returns a GPA, assigning it to 'real_gfn' seems obviously
      wrong. There is no real issue because both 'gpa_t' and 'gfn_t' are u64 and
      we don't use the value in 'real_gfn' as a GFN, we do
      
       real_gfn = gpa_to_gfn(real_gfn);
      
      instead. 'If you see a "buffalo" sign on an elephant's cage, do not trust
      your eyes', but let's fix it for good.
      
      No functional change intended.
      
      Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
      Message-Id: <20200622151435.752560-1-vkuznets@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      312d16c7
    • Paolo Bonzini's avatar
      KVM: LAPIC: ensure APIC map is up to date on concurrent update requests · 44d52717
      Paolo Bonzini authored
      
      
      The following race can cause lost map update events:
      
               cpu1                            cpu2
      
                                      apic_map_dirty = true
        ------------------------------------------------------------
                                      kvm_recalculate_apic_map:
                                           pass check
                                               mutex_lock(&kvm->arch.apic_map_lock);
                                               if (!kvm->arch.apic_map_dirty)
                                           and in process of updating map
        -------------------------------------------------------------
          other calls to
             apic_map_dirty = true         might be too late for affected cpu
        -------------------------------------------------------------
                                           apic_map_dirty = false
        -------------------------------------------------------------
          kvm_recalculate_apic_map:
          bail out on
            if (!kvm->arch.apic_map_dirty)
      
      To fix it, record the beginning of an update of the APIC map in
      apic_map_dirty.  If another APIC map change switches apic_map_dirty
      back to DIRTY during the update, kvm_recalculate_apic_map should not
      make it CLEAN, and the other caller will go through the slow path.
      
      Reported-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      44d52717
    • Linus Torvalds's avatar
      Merge tag 'spi-fix-v5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi · dd0d7181
      Linus Torvalds authored
      Pull spi fixes from Mark Brown:
       "Quite a lot of fixes here for no single reason.
      
        There's a collection of the usual sort of device specific fixes and
        also a bunch of people have been working on spidev and the userspace
        test program spidev_test so they've got an unusually large collection
        of small fixes"
      
      * tag 'spi-fix-v5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
        spi: spidev: fix a potential use-after-free in spidev_release()
        spi: spidev: fix a race between spidev_release and spidev_remove
        spi: stm32-qspi: Fix error path in case of -EPROBE_DEFER
        spi: uapi: spidev: Use TABs for alignment
        spi: spi-fsl-dspi: Free DMA memory with matching function
        spi: tools: Add macro definitions to fix build errors
        spi: tools: Make default_tx/rx and input_tx static
        spi: dt-bindings: amlogic, meson-gx-spicc: Fix schema for meson-g12a
        spi: rspi: Use requested instead of maximum bit rate
        spi: spidev_test: Use %u to format unsigned numbers
        spi: sprd: switch the sequence of setting WDG_LOAD_LOW and _HIGH
      dd0d7181
    • Igor Mammedov's avatar
      kvm: lapic: fix broken vcpu hotplug · af28dfac
      Igor Mammedov authored
      Guest fails to online hotplugged CPU with error
        smpboot: do_boot_cpu failed(-1) to wakeup CPU#4
      
      It's caused by the fact that kvm_apic_set_state(), which used to call
      recalculate_apic_map() unconditionally and pulled hotplugged CPU into
      apic map, is updating map conditionally on state changes.  In this case
      the APIC map is not considered dirty and the is not updated.
      
      Fix the issue by forcing unconditional update from kvm_apic_set_state(),
      like it used to be.
      
      Fixes: 4abaffce
      
       ("KVM: LAPIC: Recalculate apic map in batch")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Message-Id: <20200622160830.426022-1-imammedo@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      af28dfac
    • Linus Torvalds's avatar
      Merge tag 'regulator-fix-v5.8-rc2' of... · 75164578
      Linus Torvalds authored
      Merge tag 'regulator-fix-v5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
      
      Pull regulator fixes from Mark Brown:
       "This has a fix for the refactoring out of the pickable ranges
        functionality, plus the removal of a BROKEN dependency on mt6358 now
        that the dependencies were merged in -rc1 and a couple of device
        specific fixes"
      
      * tag 'regulator-fix-v5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator:
        regulator: mt6358: Remove BROKEN dependency
        regualtor: pfuze100: correct sw1a/sw2 on pfuze3000
        regulator: Fix pickable ranges mapping
        regulator: da9063: fix LDO9 suspend and warning.
      75164578
    • Linus Torvalds's avatar
      Merge tag 'regmap-fix-v5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap · 2a000870
      Linus Torvalds authored
      Pull regmap fixes from Mark Brown:
       "A few small fixes, none of which are likely to have any substantial
        impact here - the most substantial one is a fix for a long standing
        memory leak on devices that use register patching which will only have
        an impact if the device is removed and re-added"
      
      * tag 'regmap-fix-v5.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap:
        regmap: Fix memory leak from regmap_register_patch
        regmap: fix the kerneldoc for regmap_test_bits()
        regmap: fix alignment issue
      2a000870
    • Eugenio Pérez's avatar
      tools/virtio: Use tools/include/list.h instead of stubs · cb91909e
      Eugenio Pérez authored
      
      
      It should not make any significant difference but reduce stub code.
      
      Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
      Link: https://lore.kernel.org/r/20200418102217.32327-9-eperezma@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      cb91909e
    • Eugenio Pérez's avatar
      tools/virtio: Reset index in virtio_test --reset. · 1d8bf5c3
      Eugenio Pérez authored
      
      
      This way behavior for vhost is more like a VM.
      
      Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
      Link: https://lore.kernel.org/r/20200418102217.32327-8-eperezma@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      1d8bf5c3
    • Eugenio Pérez's avatar
      tools/virtio: Extract virtqueue initialization in vq_reset · 67412392
      Eugenio Pérez authored
      
      
      So we can reset after that in the main loop.
      
      Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
      Link: https://lore.kernel.org/r/20200418102217.32327-7-eperezma@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      67412392
    • Eugenio Pérez's avatar
      tools/virtio: Use __vring_new_virtqueue in virtio_test.c · 4cfb9393
      Eugenio Pérez authored
      As updated in ("2a2d1382
      
       virtio: Add improved queue allocation API")
      
      Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
      Link: https://lore.kernel.org/r/20200418102217.32327-6-eperezma@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      4cfb9393
    • Eugenio Pérez's avatar
      tools/virtio: Add --reset · 264ee5aa
      Eugenio Pérez authored
      
      
      Currently, it only removes and add backend, but it will reset vq
      position in future commits.
      
      Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
      Link: https://lore.kernel.org/r/20200418102217.32327-5-eperezma@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      264ee5aa
    • Eugenio Pérez's avatar
      tools/virtio: Add --batch=random option · 7add78b2
      Eugenio Pérez authored
      
      
      So we can test with non-deterministic batches in flight.
      
      Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
      Link: https://lore.kernel.org/r/20200418102217.32327-4-eperezma@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      7add78b2
    • Eugenio Pérez's avatar
      tools/virtio: Add --batch option · 633fae33
      Eugenio Pérez authored
      
      
      This allow to test vhost having >1 buffers in flight
      
      Signed-off-by: default avatarEugenio Pérez <eperezma@redhat.com>
      Link: https://lore.kernel.org/r/20200401183118.8334-5-eperezma@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Link: https://lore.kernel.org/r/20200418102217.32327-3-eperezma@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      633fae33
    • David Hildenbrand's avatar
      virtio-mem: add memory via add_memory_driver_managed() · b3562c60
      David Hildenbrand authored
      Virtio-mem managed memory is always detected and added by the virtio-mem
      driver, never using something like the firmware-provided memory map.
      This is the case after an ordinary system reboot, and has to be guaranteed
      after kexec. Especially, virtio-mem added memory resources can contain
      inaccessible parts ("unblocked memory blocks"), blindly forwarding them
      to a kexec kernel is dangerous, as unplugged memory will get accessed
      (esp. written).
      
      Let's use the new way of adding special driver-managed memory introduced
      in commit 7b7b2721 ("mm/memory_hotplug: introduce
      add_memory_driver_managed()").
      
      This will result in no entries in /sys/firmware/memmap ("raw firmware-
      provided memory map"), the memory resource will be flagged
      IORESOURCE_MEM_DRIVER_MANAGED (esp., kexec_file_load() will not place
      kexec images on this memory), and it is exposed as "System RAM
      (virtio_mem)" in /proc/iomem, so esp. kexec-tools can properly handle it.
      
      Example /proc/iomem before this change:
        [...]
        140000000-333ffffff : virtio0
          140000000-147ffffff : System RAM
        334000000-533ffffff : virtio1
          338000000-33fffffff : System RAM
          340000000-347ffffff : System RAM
          348000000-34fffffff : System RAM
        [...]
      
      Example /proc/iomem after this change:
        [...]
        140000000-333ffffff : virtio0
          140000000-147ffffff : System RAM (virtio_mem)
        334000000-533ffffff : virtio1
          338000000-33fffffff : System RAM (virtio_mem)
          340000000-347ffffff : System RAM (virtio_mem)
          348000000-34fffffff : System RAM (virtio_mem)
        [...]
      
      Cc: "Michael S. Tsirkin" <mst@redhat.com>
      Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
      Cc: teawater <teawaterz@linux.alibaba.com>
      Fixes: 5f1f79bb
      
       ("virtio-mem: Paravirtualized memory hotplug")
      Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
      Link: https://lore.kernel.org/r/20200611093518.5737-1-david@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarPankaj Gupta <pankaj.gupta.linux@gmail.com>
      b3562c60
    • Dan Carpenter's avatar
      virtio-mem: silence a static checker warning · 1c3d69ab
      Dan Carpenter authored
      Smatch complains that "rc" can be uninitialized if we hit the "break;"
      statement on the first iteration through the loop.  I suspect that this
      can't happen in real life, but returning a zero literal is cleaner and
      silence the static checker warning.
      
      Fixes: 5f1f79bb
      
       ("virtio-mem: Paravirtualized memory hotplug")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Link: https://lore.kernel.org/r/20200610085911.GC5439@mwanda
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      1c3d69ab
    • Dan Carpenter's avatar
      vhost_vdpa: Fix potential underflow in vhost_vdpa_mmap() · c09cc2c3
      Dan Carpenter authored
      The "vma->vm_pgoff" variable is an unsigned long so if it's larger than
      INT_MAX then "index" can be negative leading to an underflow.  Fix this
      by changing the type of "index" to "unsigned long".
      
      Fixes: ddd89d0a
      
       ("vhost_vdpa: support doorbell mapping via mmap")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Link: https://lore.kernel.org/r/20200610085852.GB5439@mwanda
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      c09cc2c3
    • Jason Wang's avatar
      vdpa: fix typos in the comments for __vdpa_alloc_device() · 24eae8eb
      Jason Wang authored
      
      
      Fix two typos in the comments for __vdpa_alloc_device().
      
      Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
      Link: https://lore.kernel.org/r/20200527060528.9100-1-jasowang@redhat.com
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      24eae8eb
  5. Jun 22, 2020
    • Takashi Iwai's avatar
      Merge tag 'asoc-fix-v5.8-rc2' of... · 91ef3d9f
      Takashi Iwai authored
      Merge tag 'asoc-fix-v5.8-rc2' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-linus
      
      ASoC: Fixes for v5.8
      
      This is a collection of mostly small fixes, mostly fixing fallout from
      some of the DPCM changes that went in last time around which shook out
      some issues on i.MX and Qualcomm platforms.  The addition of a managed
      version of snd_soc_register_dai() is to fix resource leaks.
      
      There's also a few new device IDs for x86 systems.
      91ef3d9f
    • Jason A. Donenfeld's avatar
      Revert "kernel/printk: add kmsg SEEK_CUR handling" · 625d3449
      Jason A. Donenfeld authored
      This reverts commit 8ece3b3e
      
      .
      
      This commit broke userspace. Bash uses ESPIPE to determine whether or
      not the file should be read using "unbuffered I/O", which means reading
      1 byte at a time instead of 128 bytes at a time. I used to use bash to
      read through kmsg in a really quite nasty way:
      
          while read -t 0.1 -r line 2>/dev/null || [[ $? -ne 142 ]]; do
             echo "SARU $line"
          done < /dev/kmsg
      
      This will show all lines that can fit into the 128 byte buffer, and skip
      lines that don't. That's pretty awful, but at least it worked.
      
      With this change, bash now tries to do 1-byte reads, which means it
      skips all the lines, which is worse than before.
      
      Now, I don't really care very much about this, and I'm already look for
      a workaround. But I did just spend an hour trying to figure out why my
      scripts were broken. Either way, it makes no difference to me personally
      whether this is reverted, but it might be something to consider. If you
      declare that "trying to read /dev/kmsg with bash is terminally stupid
      anyway," I might be inclined to agree with you. But do note that bash
      uses lseek(fd, 0, SEEK_CUR)==>ESPIPE to determine whether or not it's
      reading from a pipe.
      
      Cc: Bruno Meneguele <bmeneg@redhat.com>
      Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Cc: David Laight <David.Laight@ACULAB.COM>
      Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
      Cc: Petr Mladek <pmladek@suse.com>
      Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      625d3449
    • Linus Torvalds's avatar
      Linux 5.8-rc2 · 48778464
      Linus Torvalds authored
      v5.8-rc2
      48778464