Skip to content
Commit 8f8abb86 authored by Javier Carrasco's avatar Javier Carrasco Committed by Jakub Kicinski
Browse files

net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read



syzbot has found an uninit-value bug triggered by the dm9601 driver [1].

This error happens because the variable res is not updated if the call
to dm_read_shared_word returns an error. In this particular case -EPROTO
was returned and res stayed uninitialized.

This can be avoided by checking the return value of dm_read_shared_word
and propagating the error if the read operation failed.

[1] https://syzkaller.appspot.com/bug?extid=1f53a30781af65d2c955

Cc: stable@vger.kernel.org
Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Reported-and-tested-by: default avatar <syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com>
Acked-by: default avatarPeter Korsgaard <peter@korsgaard.com>
Fixes: d0374f4f

 ("USB: Davicom DM9601 usbnet driver")
Link: https://lore.kernel.org/r/20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ad98426a
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment