Skip to content
Commit 649c3fed authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

eth: bnxt: fix the wake condition



The down condition should be the negation of the wake condition,
IOW when I moved it from:

 if (cond && wake())
to
 if (__netif_txq_completed_wake(cond))

Cond should have been negated. Flip it now.

This bug leads to occasional crashes with netconsole.
It may also lead to queue never waking up in case BQL is not enabled.

Reported-by: default avatarDavid Wei <davidhwei@meta.com>
Fixes: 08a09678

 ("bnxt: use new queue try_stop/try_wake macros")
Reviewed-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20230607010826.960226-1-kuba@kernel.org
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c9d99cfa
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment