Skip to content
Commit 5a5ec83d authored by Andreas Gruenbacher's avatar Andreas Gruenbacher
Browse files

gfs2: Fix sign extension bug in gfs2_update_stats

Commit 4d207133 changed the types of the statistic values in struct
gfs2_lkstats from s64 to u64.  Because of that, what should be a signed
value in gfs2_update_stats turned into an unsigned value.  When shifted
right, we end up with a large positive value instead of a small negative
value, which results in an incorrect variance estimate.

Fixes: 4d207133

 ("gfs2: Make statistics unsigned, suitable for use with do_div()")
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
Cc: stable@vger.kernel.org # v4.4+
parent a188339c
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment