- Dec 17, 2021
-
-
Thomas Gleixner authored
Replace the about to vanish iterators and make use of the filtering. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210748.576162169@linutronix.de
-
Thomas Gleixner authored
Replace the about to vanish iterators and make use of the filtering. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210748.522641685@linutronix.de
-
Thomas Gleixner authored
Replace the about to vanish iterators and make use of the filtering. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210748.468512783@linutronix.de
-
Thomas Gleixner authored
Replace the about to vanish iterators and make use of the filtering. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210748.414712173@linutronix.de
-
Thomas Gleixner authored
Replace the about to vanish iterators and make use of the filtering. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210748.359766435@linutronix.de
-
Thomas Gleixner authored
Replace the about to vanish iterators and make use of the filtering. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Niklas Schnelle <schnelle@linux.ibm.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Niklas Schnelle <schnelle@linux.ibm.com> Link: https://lore.kernel.org/r/20211206210748.305656158@linutronix.de
-
Thomas Gleixner authored
Replace the about to vanish iterators. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210748.251752714@linutronix.de
-
Thomas Gleixner authored
Replace the about to vanish iterators. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210748.198359105@linutronix.de
-
Thomas Gleixner authored
Use the new iterator functions which pave the way for dynamically extending MSI-X vectors. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Link: https://lore.kernel.org/r/20211206210748.142603657@linutronix.de
-
Thomas Gleixner authored
Set the domain info flag which tells the core code to free the MSI descriptors from msi_domain_free_irqs() and add an explicit call to the core function into the legacy code. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Link: https://lore.kernel.org/r/20211206210748.089085131@linutronix.de
-
Thomas Gleixner authored
Simplify the allocation of MSI descriptors by using msi_add_msi_desc() which moves the storage handling to core code and prepares for dynamic extension of the MSI-X vector space. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Link: https://lore.kernel.org/r/20211206210748.035348646@linutronix.de
-
Thomas Gleixner authored
To prepare for dynamic extension of MSI-X vectors, protect the MSI operations for MSI and MSI-X. This requires to move the invocation of irq_create_affinity_masks() out of the descriptor lock section to avoid reverse lock ordering vs. CPU hotplug lock as some callers of the PCI/MSI allocation interfaces already hold it. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Link: https://lore.kernel.org/r/20211206210747.982292705@linutronix.de
-
Thomas Gleixner authored
Provide domain info flags which tell the core to allocate simple descriptors or to free descriptors when the interrupts are freed and implement the required functionality. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210747.928198636@linutronix.de
-
Thomas Gleixner authored
Provide msi_alloc_msi_desc() which takes a template MSI descriptor for initializing a newly allocated descriptor. This allows to simplify various usage sites of alloc_msi_entry() and moves the storage handling into the core code. For simple cases where only a linear vector space is required provide msi_add_simple_msi_descs() which just allocates a linear range of MSI descriptors and fills msi_desc::msi_index accordingly. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210747.873833567@linutronix.de
-
Thomas Gleixner authored
In preparation for dynamic handling of MSI-X interrupts provide a new set of MSI descriptor accessor functions and iterators. They are benefitial per se as they allow to cleanup quite some code in various MSI domain implementations. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210747.818635078@linutronix.de
-
Thomas Gleixner authored
Usage sites which do allocations of the MSI descriptors before invoking msi_domain_alloc_irqs() require to lock the MSI decriptors accross the operation. Provide entry points which can be called with the MSI mutex held and lock the mutex in the existing entry points. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210747.765371053@linutronix.de
-
Thomas Gleixner authored
For upcoming runtime extensions of MSI-X interrupts it's required to protect the MSI descriptor list. Add a mutex to struct msi_device_data and provide lock/unlock functions. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210747.708877269@linutronix.de
-
Thomas Gleixner authored
It's only required when MSI is in use. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211206210747.650487479@linutronix.de
-
Thomas Gleixner authored
There is no reason to walk the MSI descriptors to retrieve the interrupt number for a device. Use msi_get_virq() instead. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Sinan Kaya <okaya@kernel.org> Acked-by:
Vinod Koul <vkoul@kernel.org> Link: https://lore.kernel.org/r/20211210221815.329792721@linutronix.de
-
Thomas Gleixner authored
Just use the core function msi_get_virq(). Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Arnd Bergmann <arnd@arndb.de> Acked-by:
Vinod Koul <vkoul@kernel.org> Acked-by:
Nishanth Menon <nm@ti.com> Link: https://lore.kernel.org/r/20211210221815.269468319@linutronix.de
-
Thomas Gleixner authored
Storing a pointer to the MSI descriptor just to track the Linux interrupt number is daft. Just store the interrupt number and be done with it. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221815.207838579@linutronix.de
-
Thomas Gleixner authored
No point in retrieving the MSI descriptors. Just query the Linux interrupt number. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221815.148331680@linutronix.de
-
Thomas Gleixner authored
Let the core code fiddle with the MSI descriptor retrieval. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Robin Murphy <robin.murphy@arm.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221815.089008198@linutronix.de
-
Thomas Gleixner authored
Let the core code fiddle with the MSI descriptor retrieval. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221815.029143589@linutronix.de
-
Thomas Gleixner authored
Storing a pointer to the MSI descriptor just to keep track of the Linux interrupt number is daft. Use msi_get_virq() instead. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Vinod Koul <vkoul@kernel.org> Link: https://lore.kernel.org/r/20211210221814.970099984@linutronix.de
-
Thomas Gleixner authored
Replace open coded MSI descriptor chasing and use the proper accessor functions instead. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.900929381@linutronix.de
-
Thomas Gleixner authored
Use msi_get_vector() and handle the return value to be compatible. No functional change intended. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.841243231@linutronix.de
-
Thomas Gleixner authored
This allows drivers to retrieve the Linux interrupt number instead of fiddling with MSI descriptors. msi_get_virq() returns the Linux interrupt number or 0 in case that there is no entry for the given MSI index. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.780824745@linutronix.de
-
Thomas Gleixner authored
Set the domain info flag and remove the check. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.720998720@linutronix.de
-
Thomas Gleixner authored
Provide a domain info flag which makes the core code check for a contiguous MSI-X index on allocation. That's simpler than checking it at some other domain callback in architecture code. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Link: https://lore.kernel.org/r/20211210221814.662401116@linutronix.de
-
Thomas Gleixner authored
The usage of msi_desc::pci::entry_nr is confusing at best. It's the index into the MSI[X] descriptor table. Use msi_desc::msi_index which is shared between all MSI incarnations instead of having a PCI specific storage for no value. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Link: https://lore.kernel.org/r/20211210221814.602911509@linutronix.de
-
Thomas Gleixner authored
Use the common msi_index member and get rid of the pointless wrapper struct. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Nishanth Menon <nm@ti.com> Link: https://lore.kernel.org/r/20211210221814.540704224@linutronix.de
-
Thomas Gleixner authored
Use the common msi_index member and get rid of the pointless wrapper struct. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.477386185@linutronix.de
-
Thomas Gleixner authored
Use the common msi_index member and get rid of the pointless wrapper struct. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.413638645@linutronix.de
-
Thomas Gleixner authored
All non PCI/MSI usage variants have data structures in struct msi_desc with only one member: xxx_index. PCI/MSI has a entry_nr member. Add a common msi_index member to struct msi_desc so all implementations can share it which allows further consolidation. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.350967317@linutronix.de
-
Thomas Gleixner authored
Storing the platform private data in a MSI descriptor is sloppy at best. The data belongs to the device and not to the descriptor. Add a pointer to struct msi_device_data and store the pointer there. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.287680528@linutronix.de
-
Thomas Gleixner authored
It's hard to distinguish what platform_msi_domain_alloc() and platform_msi_domain_alloc_irqs() are about. Make the distinction more explicit and add comments which explain the use cases properly. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.228706214@linutronix.de
-
Thomas Gleixner authored
No more users. Refactor the core code accordingly and move the global interface under CONFIG_PCI_MSI_ARCH_FALLBACKS. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.168362229@linutronix.de
-
Thomas Gleixner authored
Set the domain info flag and remove the local sysfs code. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Link: https://lore.kernel.org/r/20211210221814.109408832@linutronix.de
-
Thomas Gleixner authored
Set the domain info flag which makes the core code handle sysfs groups and put an explicit invocation into the legacy code. Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Tested-by:
Michael Kelley <mikelley@microsoft.com> Tested-by:
Nishanth Menon <nm@ti.com> Reviewed-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by:
Jason Gunthorpe <jgg@nvidia.com> Acked-by:
Bjorn Helgaas <bhelgaas@google.com> Link: https://lore.kernel.org/r/20211210221814.048612053@linutronix.de
-