debugfs: return error values, not NULL
When an error happens, debugfs should return an error pointer value, not NULL. This will prevent the totally theoretical error where a debugfs call fails due to lack of memory, returning NULL, and that dentry value is then passed to another debugfs call, which would end up succeeding, creating a file at the root of the debugfs tree, but would then be impossible to remove (because you can not remove the directory NULL). So, to make everyone happy, always return errors, this makes the users of debugfs much simpler (they do not have to ever check the return value), and everyone can rest easy. Reported-by:Gary R Hook <ghook@amd.com> Reported-by:
Heiko Carstens <heiko.carstens@de.ibm.com> Reported-by:
Masami Hiramatsu <mhiramat@kernel.org> Reported-by:
Michal Hocko <mhocko@kernel.org> Reported-by:
Sebastian Andrzej Siewior <bigeasy@linutronix.de> Reported-by:
Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by:
Masami Hiramatsu <mhiramat@kernel.org> Reviewed-by:
Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
d88c93f0
-
mentioned in commit 3f42c000
-
mentioned in commit f4d67769
-
mentioned in commit e36f752d
-
mentioned in commit af505cad
-
mentioned in commit 3bef1b72
-
mentioned in commit 91d5de0b
-
mentioned in commit ec889a8b
-
mentioned in commit d23385a2
-
mentioned in commit d974330c
-
mentioned in commit cafa2ad4
-
mentioned in commit 73b8e217
Please register or sign in to comment