Skip to content
Commit e0b99200 authored by Colin Ian King's avatar Colin Ian King Committed by Ben Hutchings
Browse files

rtc: ds1672: fix unintended sign extension

commit f0c04c27 upstream.

Shifting a u8 by 24 will cause the value to be promoted to an integer. If
the top bit of the u8 is set then the following conversion to an unsigned
long will sign extend the value causing the upper 32 bits to be set in
the result.

Fix this by casting the u8 value to an unsigned long before the shift.

Detected by CoverityScan, CID#138801 ("Unintended sign extension")

Fixes: edf1aaa3

 ("[PATCH] RTC subsystem: DS1672 driver")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 3e45c855
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment