Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put
This fixes the following trace which is caused by hci_rx_work starting up *after* the final channel reference has been put() during sock_close() but *before* the references to the channel have been destroyed, so instead the code now rely on kref_get_unless_zero/l2cap_chan_hold_unless_zero to prevent referencing a channel that is about to be destroyed. refcount_t: increment on 0; use-after-free. BUG: KASAN: use-after-free in refcount_dec_and_test+0x20/0xd0 Read of size 4 at addr ffffffc114f5bf18 by task kworker/u17:14/705 CPU: 4 PID: 705 Comm: kworker/u17:14 Tainted: G S W 4.14.234-00003-g1fb6d0bd49a4-dirty #28 Hardware name: Qualcomm Technologies, Inc. SM8150 V2 PM8150 Google Inc. MSM sm8150 Flame DVT (DT) Workqueue: hci0 hci_rx_work Call trace: dump_backtrace+0x0/0x378 show_stack+0x20/0x2c dump_stack+0x124/0x148 print_address_description+0x80/0x2e8 __kasan_report+0x168/0x188 kasan_report+0x10/0x18 __asan_load4+0x84/0x8c refcount_dec_and_test+0x20/0xd0 l2cap_chan_put+0x48/0x12c l2cap_recv_frame+0x4770/0x6550 l2cap_recv_acldata+0x44c/0x7a4 hci_acldata_packet+0x100/0x188 hci_rx_work+0x178/0x23c process_one_work+0x35c/0x95c worker_thread+0x4cc/0x960 kthread+0x1a8/0x1c4 ret_from_fork+0x10/0x18 Cc: stable@kernel.org Reported-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Tested-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent
ef61b6ea
-
mentioned in commit de5d4654
-
mentioned in commit f32d5615
-
mentioned in commit 59a55ec3
-
mentioned in commit 098e07ef
-
mentioned in commit bbd1fdb0
-
mentioned in commit 2711beda
-
mentioned in commit 11e008e5
-
mentioned in commit 8422e81f
-
mentioned in commit c898e917
-
mentioned in commit 5f776b8b
-
mentioned in commit a55ac441
-
mentioned in commit d255c861
-
mentioned in commit 33f4098a
-
mentioned in commit 0d0e2d03
-
mentioned in commit 17c61648
-
mentioned in commit 7f7bfdd9
-
mentioned in commit db4a0783
-
mentioned in commit d9ec6e2f
-
mentioned in commit a3a7b2ac
-
mentioned in commit c1f594dd
-
mentioned in commit a2a9339e
-
mentioned in commit f2d38e77
-
mentioned in commit 1351551a
-
mentioned in commit d9ba36c2
-
mentioned in commit ac6725a6
-
mentioned in commit c0242199
Please register or sign in to comment