NFSv4 fix CLOSE not waiting for direct IO compeletion
Figuring out the root case for the REMOVE/CLOSE race and suggesting the solution was done by Neil Brown. Currently what happens is that direct IO calls hold a reference on the open context which is decremented as an asynchronous task in the nfs_direct_complete(). Before reference is decremented, control is returned to the application which is free to close the file. When close is being processed, it decrements its reference on the open_context but since directIO still holds one, it doesn't sent a close on the wire. It returns control to the application which is free to do other operations. For instance, it can delete a file. Direct IO is finally releasing its reference and triggering an asynchronous close. Which races with the REMOVE. On the server, REMOVE can be processed before the CLOSE, failing the REMOVE with EACCES as the file is still opened. Signed-off-by: Olga Kornievskaia <kolga@netapp.com> Suggested-by: Neil Brown <neilb@suse.com> CC: stable@vger.kernel.org Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
parent
8b040137
-
mentioned in commit 76c3f19c
-
mentioned in commit e66a37c8
-
mentioned in commit cff6b731
-
mentioned in commit 5c85c81e
-
mentioned in commit 4d35ca87
-
mentioned in commit 7f7f6661
-
mentioned in commit 930aee1d
-
mentioned in commit 8f0d0b36
-
mentioned in commit 81475c5d
-
mentioned in commit 968bef60
Please register or sign in to comment