btrfs: raid56: simplify tracking of Q stripe presence
There are temporary variables tracking the index of P and Q stripes, but none of them is really used as such, merely for determining if the Q stripe is present. This leads to compiler warnings with -Wunused-but-set-variable and has been reported several times. fs/btrfs/raid56.c: In function ‘finish_rmw’: fs/btrfs/raid56.c:1199:6: warning: variable ‘p_stripe’ set but not used [-Wunused-but-set-variable] 1199 | int p_stripe = -1; | ^~~~~~~~ fs/btrfs/raid56.c: In function ‘finish_parity_scrub’: fs/btrfs/raid56.c:2356:6: warning: variable ‘p_stripe’ set but not used [-Wunused-but-set-variable] 2356 | int p_stripe = -1; | ^~~~~~~~ Replace the two variables with one that has a clear meaning and also get rid of the warnings. The logic that verifies that there are only 2 valid cases is unchanged. Reviewed-by:Johannes Thumshirn <johannes.thumshirn@wdc.com> Signed-off-by:
David Sterba <dsterba@suse.com>
parent
b25b0b87
-
mentioned in commit b2a48761
-
mentioned in commit 52d36f5a
-
mentioned in commit 909a8d2b
-
mentioned in commit 0c740d2b
-
mentioned in commit b41908a3
-
mentioned in commit 92a3eecc
-
mentioned in commit c1a77dbc
-
mentioned in commit 78abc4fb
-
mentioned in commit 1c3c5136
-
mentioned in commit 6d511a8b
Please register or sign in to comment