Skip to content
Commit bea2662e authored by Johannes Berg's avatar Johannes Berg Committed by Kalle Valo
Browse files

iwlwifi: fix use-after-free



If no firmware was present at all (or, presumably, all of the
firmware files failed to parse), we end up unbinding by calling
device_release_driver(), which calls remove(), which then in
iwlwifi calls iwl_drv_stop(), freeing the 'drv' struct. However
the new code I added will still erroneously access it after it
was freed.

Set 'failure=false' in this case to avoid the access, all data
was already freed anyway.

Cc: stable@vger.kernel.org
Reported-by: default avatarStefan Agner <stefan@agner.ch>
Reported-by: default avatarWolfgang Walter <linux@stwm.de>
Reported-by: default avatarJason Self <jason@bluehome.net>
Reported-by: default avatarDominik Behr <dominik@dominikbehr.com>
Reported-by: default avatarMarek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Fixes: ab07506b

 ("iwlwifi: fix leaks/bad data after failed firmware load")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220208114728.e6b514cf4c85.Iffb575ca2a623d7859b542c33b2a507d01554251@changeid
parent f0a6fd15
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment