Skip to content
Commit b4066eb0 authored by Siddh Raman Pant's avatar Siddh Raman Pant Committed by Luiz Augusto von Dentz
Browse files

Bluetooth: hci_conn: return ERR_PTR instead of NULL when there is no link



hci_connect_sco currently returns NULL when there is no link (i.e. when
hci_conn_link() returns NULL).

sco_connect() expects an ERR_PTR in case of any error (see line 266 in
sco.c). Thus, hcon set as NULL passes through to sco_conn_add(), which
tries to get hcon->hdev, resulting in dereferencing a NULL pointer as
reported by syzkaller.

The same issue exists for iso_connect_cis() calling hci_connect_cis().

Thus, make hci_connect_sco() and hci_connect_cis() return ERR_PTR
instead of NULL.

Reported-and-tested-by: default avatar <syzbot+37acd5d80d00d609d233@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=37acd5d80d00d609d233
Fixes: 06149746

 ("Bluetooth: hci_conn: Add support for linking multiple hcon")
Signed-off-by: default avatarSiddh Raman Pant <code@siddh.me>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent de6dfcef
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment