Skip to content
Commit a754de70 authored by Eric Biggers's avatar Eric Biggers Committed by Greg Kroah-Hartman
Browse files

tty: fix compat TIOCGSERIAL leaking uninitialized memory

commit 17329563 upstream.

Commit 77654350

 ("take compat TIOC[SG]SERIAL treatment into
tty_compat_ioctl()") changed the compat version of TIOCGSERIAL to start
copying a whole 'serial_struct32' to userspace rather than individual
fields, but failed to initialize all padding and fields -- namely the
hole after the 'iomem_reg_shift' field, and the 'reserved' field.

Fix this by initializing the struct to zero.

[v2: use sizeof, and convert the adjacent line for consistency.]

Reported-by: default avatar <syzbot+8da9175e28eadcb203ce@syzkaller.appspotmail.com>
Fixes: 77654350

 ("take compat TIOC[SG]SERIAL treatment into tty_compat_ioctl()")
Cc: <stable@vger.kernel.org> # v4.20+
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Acked-by: default avatarJiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20200224182044.234553-2-ebiggers@kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 279cdccb
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment